Re: [Xen-devel] [PATCH v2 04/10] xen: credit2: only reset credit on reset condition

2016-09-30 Thread Dario Faggioli
On Fri, 2016-09-30 at 13:25 +0100, anshul makkar wrote: > On 30/09/16 03:53, Dario Faggioli wrote: > > @@ -2336,6 +2345,7 @@ csched2_schedule( > >  struct csched2_runqueue_data *rqd; > >  struct csched2_vcpu * const scurr = CSCHED2_VCPU(current); > >  struct csched2_vcpu *snext = NULL;

Re: [Xen-devel] [PATCH v2 04/10] xen: credit2: only reset credit on reset condition

2016-09-30 Thread anshul makkar
On 30/09/16 03:53, Dario Faggioli wrote: The condition for a Credit2 scheduling epoch coming to an end is that the vcpu at the front of the runqueue has negative credits. However, it is possible, that runq_candidate() does not actually return to the scheduler the first vcpu in the runqueue (e.g.,

Re: [Xen-devel] [PATCH v2 04/10] xen: credit2: only reset credit on reset condition

2016-09-30 Thread George Dunlap
On 30/09/16 03:53, Dario Faggioli wrote: > The condition for a Credit2 scheduling epoch coming to an > end is that the vcpu at the front of the runqueue has negative > credits. However, it is possible, that runq_candidate() does > not actually return to the scheduler the first vcpu in the > runqueu

[Xen-devel] [PATCH v2 04/10] xen: credit2: only reset credit on reset condition

2016-09-29 Thread Dario Faggioli
The condition for a Credit2 scheduling epoch coming to an end is that the vcpu at the front of the runqueue has negative credits. However, it is possible, that runq_candidate() does not actually return to the scheduler the first vcpu in the runqueue (e.g., because such vcpu can't run on the cpu tha