Re: [Xen-devel] [PATCH v2 03/17] x86/hvm: unify internal portio and mmio intercepts

2015-06-17 Thread Jan Beulich
>>> On 17.06.15 at 16:40, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 17 June 2015 15:23 >> >>> On 11.06.15 at 17:42, wrote: >> > +case IOREQ_TYPE_COPY: >> > +if ( p->df ) >> > { >> > -if ( vio->mmio_large_read_bytes != p->size

Re: [Xen-devel] [PATCH v2 03/17] x86/hvm: unify internal portio and mmio intercepts

2015-06-17 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 17 June 2015 15:23 > To: Paul Durrant > Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: Re: [PATCH v2 03/17] x86/hvm: unify internal portio and mmio > intercepts > > >>> On 11.06.15 at

Re: [Xen-devel] [PATCH v2 03/17] x86/hvm: unify internal portio and mmio intercepts

2015-06-17 Thread Jan Beulich
>>> On 11.06.15 at 17:42, wrote: > - fail2: > + fail6: > rtc_deinit(d); > stdvga_deinit(d); > vioapic_deinit(d); > - fail1: > + fail5: > if ( is_hardware_domain(d) ) > xfree(d->arch.hvm_domain.io_bitmap); > -xfree(d->arch.hvm_domain.io_handler); > + fail4: > +x

[Xen-devel] [PATCH v2 03/17] x86/hvm: unify internal portio and mmio intercepts

2015-06-11 Thread Paul Durrant
The implementation of mmio and portio intercepts is unnecessarily different. This leads to much code duplication. This patch unifies much of the intercept handling, leaving only distinct handlers for stdvga mmio and dpci portio. Subsequent patches will unify those handlers. Signed-off-by: Paul Dur