Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Andrew Cooper
On 15/11/16 16:58, Boris Ostrovsky wrote: > On 11/15/2016 11:33 AM, Jan Beulich wrote: > On 15.11.16 at 17:23, wrote: >>> On 11/15/2016 10:53 AM, Jan Beulich wrote: >>> On 15.11.16 at 16:41, wrote: > On 11/15/2016 10:13 AM, Jan Beulich wrote: > On 15.11.16 at 15:47, wrote: >>

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Jan Beulich
>>> On 15.11.16 at 17:58, wrote: > On 11/15/2016 11:33 AM, Jan Beulich wrote: > On 15.11.16 at 17:23, wrote: >>> On 11/15/2016 10:53 AM, Jan Beulich wrote: >>> On 15.11.16 at 16:41, wrote: > On 11/15/2016 10:13 AM, Jan Beulich wrote: > On 15.11.16 at 15:47, wrote: >>> On

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Boris Ostrovsky
On 11/15/2016 11:33 AM, Jan Beulich wrote: On 15.11.16 at 17:23, wrote: >> On 11/15/2016 10:53 AM, Jan Beulich wrote: >> On 15.11.16 at 16:41, wrote: On 11/15/2016 10:13 AM, Jan Beulich wrote: On 15.11.16 at 15:47, wrote: >> On 11/15/2016 03:47 AM, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Jan Beulich
>>> On 15.11.16 at 17:23, wrote: > On 11/15/2016 10:53 AM, Jan Beulich wrote: > On 15.11.16 at 16:41, wrote: >>> On 11/15/2016 10:13 AM, Jan Beulich wrote: >>> On 15.11.16 at 15:47, wrote: > On 11/15/2016 03:47 AM, Jan Beulich wrote: >>> --- a/tools/libacpi/static_tables.c >>

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Boris Ostrovsky
On 11/15/2016 10:53 AM, Jan Beulich wrote: On 15.11.16 at 16:41, wrote: >> On 11/15/2016 10:13 AM, Jan Beulich wrote: >> On 15.11.16 at 15:47, wrote: On 11/15/2016 03:47 AM, Jan Beulich wrote: >> --- a/tools/libacpi/static_tables.c >> +++ b/tools/libacpi/static_tables.c

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Jan Beulich
>>> On 15.11.16 at 16:41, wrote: > On 11/15/2016 10:13 AM, Jan Beulich wrote: > On 15.11.16 at 15:47, wrote: >>> On 11/15/2016 03:47 AM, Jan Beulich wrote: > --- a/tools/libacpi/static_tables.c > +++ b/tools/libacpi/static_tables.c > @@ -20,6 +20,8 @@ > * Firmware ACPI Contr

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Boris Ostrovsky
On 11/15/2016 10:13 AM, Jan Beulich wrote: On 15.11.16 at 15:47, wrote: >> On 11/15/2016 03:47 AM, Jan Beulich wrote: --- a/tools/libacpi/static_tables.c +++ b/tools/libacpi/static_tables.c @@ -20,6 +20,8 @@ * Firmware ACPI Control Structure (FACS). */

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Jan Beulich
>>> On 15.11.16 at 15:47, wrote: > On 11/15/2016 03:47 AM, Jan Beulich wrote: >> >>> --- a/tools/libacpi/static_tables.c >>> +++ b/tools/libacpi/static_tables.c >>> @@ -20,6 +20,8 @@ >>> * Firmware ACPI Control Structure (FACS). >>> */ >>> >>> +#define ACPI_REG_BIT_OFFSET0 >> Can you com

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Boris Ostrovsky
On 11/15/2016 03:47 AM, Jan Beulich wrote: > >> --- a/tools/libacpi/static_tables.c >> +++ b/tools/libacpi/static_tables.c >> @@ -20,6 +20,8 @@ >> * Firmware ACPI Control Structure (FACS). >> */ >> >> +#define ACPI_REG_BIT_OFFSET0 > Can you completely exclude us ever wanting to support so

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-15 Thread Jan Beulich
>>> On 09.11.16 at 15:39, wrote: > @@ -244,7 +245,8 @@ int main(int argc, char **argv) > #endif > > /* Operation Region 'PRST': bitmask of online CPUs. */ > -stmt("OperationRegion", "PRST, SystemIO, 0xaf00, 32"); > +stmt("OperationRegion", "PRST, SystemIO, 0x%x, %d", %#x > --- a/

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-14 Thread Andrew Cooper
On 14/11/16 15:01, Boris Ostrovsky wrote: > On 11/09/2016 04:01 PM, Boris Ostrovsky wrote: >> On 11/09/2016 02:58 PM, Andrew Cooper wrote: >>> On 09/11/16 15:14, Boris Ostrovsky wrote: On 11/09/2016 09:59 AM, Andrew Cooper wrote: >> diff --git a/xen/include/public/hvm/ioreq.h >> b/xen

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-14 Thread Boris Ostrovsky
On 11/09/2016 04:01 PM, Boris Ostrovsky wrote: > On 11/09/2016 02:58 PM, Andrew Cooper wrote: >> On 09/11/16 15:14, Boris Ostrovsky wrote: >>> On 11/09/2016 09:59 AM, Andrew Cooper wrote: > diff --git a/xen/include/public/hvm/ioreq.h > b/xen/include/public/hvm/ioreq.h > index 2e5809b..

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Boris Ostrovsky
On 11/09/2016 02:58 PM, Andrew Cooper wrote: > On 09/11/16 15:14, Boris Ostrovsky wrote: >> On 11/09/2016 09:59 AM, Andrew Cooper wrote: diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h index 2e5809b..e3fa704 100644 --- a/xen/include/public/hvm/ioreq

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Andrew Cooper
On 09/11/16 15:14, Boris Ostrovsky wrote: > On 11/09/2016 09:59 AM, Andrew Cooper wrote: >>> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h >>> index 2e5809b..e3fa704 100644 >>> --- a/xen/include/public/hvm/ioreq.h >>> +++ b/xen/include/public/hvm/ioreq.h >>> @@ -24,6

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Boris Ostrovsky
On 11/09/2016 09:59 AM, Andrew Cooper wrote: > >> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h >> index 2e5809b..e3fa704 100644 >> --- a/xen/include/public/hvm/ioreq.h >> +++ b/xen/include/public/hvm/ioreq.h >> @@ -24,6 +24,8 @@ >> #ifndef _IOREQ_H_ >> #define _IOR

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Andrew Cooper
On 09/11/16 14:39, Boris Ostrovsky wrote: > ACPI hotplug-related IO accesses (to GPE0 block) are handled > by qemu for HVM guests. Since PVH guests don't have qemu these > accesses will need to be procesed by the hypervisor. > > Because ACPI event model expects pm1a block to be present we > need to

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Boris Ostrovsky
On 11/09/2016 09:48 AM, Julien Grall wrote: > Hi Boris, > > On 09/11/16 14:39, Boris Ostrovsky wrote: >> diff --git a/xen/include/public/arch-arm.h >> b/xen/include/public/arch-arm.h >> index bd974fb..b793774 100644 >> --- a/xen/include/public/arch-arm.h >> +++ b/xen/include/public/arch-arm.h >> @@

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Paul Durrant
> -Original Message- > From: Boris Ostrovsky [mailto:boris.ostrov...@oracle.com] > Sent: 09 November 2016 14:40 > To: xen-devel@lists.xen.org > Cc: jbeul...@suse.com; Andrew Cooper ; > Wei Liu ; Ian Jackson ; Roger > Pau Monne ; Boris Ostrovsky > ; Julien Grall ; Paul > Durrant > Subject:

Re: [Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Julien Grall
Hi Boris, On 09/11/16 14:39, Boris Ostrovsky wrote: diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index bd974fb..b793774 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -383,6 +383,9 @@ typedef uint64_t xen_callback_t; * should ins

[Xen-devel] [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests

2016-11-09 Thread Boris Ostrovsky
ACPI hotplug-related IO accesses (to GPE0 block) are handled by qemu for HVM guests. Since PVH guests don't have qemu these accesses will need to be procesed by the hypervisor. Because ACPI event model expects pm1a block to be present we need to have the hypervisor emulate it as well. Signed-off-