Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-27 Thread Xu, Quan
On April 27, 2016 11:03 PM, Jan Beulich wrote: > >>> On 27.04.16 at 16:26, wrote: > > On April 25, 2016 5:27 PM, Jan Beulich wrote: > >> >>> On 18.04.16 at 16:00, wrote: > I.e. I continue to think that > > if ( is_hardware_domain() ) > printk(); > else > domain_crash();

Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 16:26, wrote: > On April 25, 2016 5:27 PM, Jan Beulich wrote: >> >>> On 18.04.16 at 16:00, wrote: >> > --- a/xen/drivers/passthrough/iommu.c >> > +++ b/xen/drivers/passthrough/iommu.c >> > @@ -243,21 +243,33 @@ int iommu_map_page(struct domain *d, >> unsigned long gfn, unsigne

Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-27 Thread Xu, Quan
On April 25, 2016 5:27 PM, Jan Beulich wrote: > >>> On 18.04.16 at 16:00, wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -243,21 +243,33 @@ int iommu_map_page(struct domain *d, > unsigned long gfn, unsigned long mfn, > > unsig

Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-25 Thread Jan Beulich
>>> On 18.04.16 at 16:00, wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -243,21 +243,33 @@ int iommu_map_page(struct domain *d, unsigned long gfn, > unsigned long mfn, > unsigned int flags) > { > struct hvm_iommu *hd = domain

Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-18 Thread Xu, Quan
On April 19, 2016 2:37pm, Tian, Kevin wrote: > > From: Quan Xu > > Sent: Monday, April 18, 2016 10:00 PM > > > > Now IOMMU mapping and unmapping failures are treated as a fatal to the > > domain (with the exception of the hardware domain). > > 'Now' is more about eixsting state, while it's actual

Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-18 Thread Tian, Kevin
> From: Quan Xu > Sent: Monday, April 18, 2016 10:00 PM > > Now IOMMU mapping and unmapping failures are treated as a fatal to > the domain (with the exception of the hardware domain). 'Now' is more about eixsting state, while it's actually what you want to change towards. Better directly say "T

[Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-18 Thread Quan Xu
Now IOMMU mapping and unmapping failures are treated as a fatal to the domain (with the exception of the hardware domain). If IOMMU mapping and unmapping failed, crash the domain (with the exception of the hardware domain) and propagate the error up to the call trees. Signed-off-by: Quan Xu CC: