Re: [Xen-devel] [PATCH v2 01/11] x86emul: catch exceptions occurring in stubs

2017-02-14 Thread Andrew Cooper
On 13/02/17 16:20, Jan Beulich wrote: On 13.02.17 at 14:58, wrote: >> On 13/02/17 11:40, Jan Beulich wrote: >> On 10.02.17 at 17:38, wrote: On 01/02/17 11:12, Jan Beulich wrote: > Before adding more use of stubs cloned from decoded guest insns, guard > ourselves against mist

Re: [Xen-devel] [PATCH v2 01/11] x86emul: catch exceptions occurring in stubs

2017-02-13 Thread Jan Beulich
>>> On 13.02.17 at 14:58, wrote: > On 13/02/17 11:40, Jan Beulich wrote: > On 10.02.17 at 17:38, wrote: >>> On 01/02/17 11:12, Jan Beulich wrote: Before adding more use of stubs cloned from decoded guest insns, guard ourselves against mistakes there: Should an exception (with the >>

Re: [Xen-devel] [PATCH v2 01/11] x86emul: catch exceptions occurring in stubs

2017-02-13 Thread Andrew Cooper
On 13/02/17 11:40, Jan Beulich wrote: On 10.02.17 at 17:38, wrote: >> On 01/02/17 11:12, Jan Beulich wrote: >>> Before adding more use of stubs cloned from decoded guest insns, guard >>> ourselves against mistakes there: Should an exception (with the >>> noteworthy exception of #PF) occur ins

Re: [Xen-devel] [PATCH v2 01/11] x86emul: catch exceptions occurring in stubs

2017-02-13 Thread Jan Beulich
>>> On 10.02.17 at 17:38, wrote: > On 01/02/17 11:12, Jan Beulich wrote: >> Before adding more use of stubs cloned from decoded guest insns, guard >> ourselves against mistakes there: Should an exception (with the >> noteworthy exception of #PF) occur inside the stub, forward it to the >> guest. >

Re: [Xen-devel] [PATCH v2 01/11] x86emul: catch exceptions occurring in stubs

2017-02-10 Thread Andrew Cooper
On 01/02/17 11:12, Jan Beulich wrote: > Before adding more use of stubs cloned from decoded guest insns, guard > ourselves against mistakes there: Should an exception (with the > noteworthy exception of #PF) occur inside the stub, forward it to the > guest. Why exclude #PF ? Nothing in a stub shou

[Xen-devel] [PATCH v2 01/11] x86emul: catch exceptions occurring in stubs

2017-02-01 Thread Jan Beulich
Before adding more use of stubs cloned from decoded guest insns, guard ourselves against mistakes there: Should an exception (with the noteworthy exception of #PF) occur inside the stub, forward it to the guest. Since the exception fixup table entry can't encode the address of the faulting insn it