Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 13:20 -0600, Charles Arnold wrote: > >>> On 3/19/2015 at 12:09 PM, Anthony PERARD > >>> wrote: > > On Wed, Mar 18, 2015 at 04:12:26PM +, Ian Campbell wrote: > >> My second concern here is with the use of /var/run/xen/qmp-libxl-%i from > >> outside of libxl. I can't reme

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 11:50 -0600, Charles Arnold wrote: > > Whether the interface exists (even in buggy form) or not in older > > versions is important because if it doesn't exist then that would be a > > build failure, which we would want to avoid. > > Right. The tree feature was added in versio

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-19 Thread Charles Arnold
>>> On 3/19/2015 at 12:09 PM, Anthony PERARD wrote: > On Wed, Mar 18, 2015 at 04:12:26PM +, Ian Campbell wrote: >> My second concern here is with the use of /var/run/xen/qmp-libxl-%i from >> outside of libxl. I can't remember if qemu is safe against multiple >> users of the socket. ISTR askin

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-19 Thread Anthony PERARD
On Wed, Mar 18, 2015 at 04:12:26PM +, Ian Campbell wrote: > My second concern here is with the use of /var/run/xen/qmp-libxl-%i from > outside of libxl. I can't remember if qemu is safe against multiple > users of the socket. ISTR asking Anthony this before, but I don't recall > the answer, sor

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-19 Thread Charles Arnold
>>> On 3/18/2015 at 10:12 AM, Ian Campbell wrote: > On Wed, 2015-03-11 at 11:51 -0600, Charles Arnold wrote: >> Now that Xen uses qdisks by default and qemu does not write out >> statistics to sysfs this patch queries the QMP for disk statistics. >> >> This patch depends on libyajl for parsing s

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-11 at 11:51 -0600, Charles Arnold wrote: > Now that Xen uses qdisks by default and qemu does not write out > statistics to sysfs this patch queries the QMP for disk statistics. > > This patch depends on libyajl for parsing statistics returned from > QMP. The runtime requires libyaj

[Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-11 Thread Charles Arnold
Now that Xen uses qdisks by default and qemu does not write out statistics to sysfs this patch queries the QMP for disk statistics. This patch depends on libyajl for parsing statistics returned from QMP. The runtime requires libyajl 2.0.3 or newer for required bug fixes in yajl_tree_parse(). No i