Felix Schmoll writes ("Re: [PATCH v2] xenconsole: Add pipe option"):
> As there is already an interactive variable in the code, it seems
> like a rather strange overloading to call the option interactive
> that directly affects a different variable (currently pipe). The
> name seems to make sense h
On Wed, Jul 19, 2017 at 11:09:57AM +0200, Felix Schmoll wrote:
> 2017-07-17 17:14 GMT+02:00 Ian Jackson :
>
> > Felix Schmoll writes ("[PATCH v2] xenconsole: Add pipe option"):
> > > Add pipe option to xenconsole that forwards console input.
> >
> > Thanks. IMO the commit message could do with be
2017-07-17 17:14 GMT+02:00 Ian Jackson :
> Felix Schmoll writes ("[PATCH v2] xenconsole: Add pipe option"):
> > Add pipe option to xenconsole that forwards console input.
>
> Thanks. IMO the commit message could do with better explanation. It
> should mention that xenconsole has a strange behavi
Felix Schmoll writes ("[PATCH v2] xenconsole: Add pipe option"):
> Add pipe option to xenconsole that forwards console input.
Thanks. IMO the commit message could do with better explanation. It
should mention that xenconsole has a strange behaviour where it
doesn't forward stdin unless stdin and
Add pipe option to xenconsole that forwards console input.
Signed-off-by: Felix Schmoll
---
Changed since v1:
* introduce separate pipe flag
* remove changes to libxl
---
tools/console/client/main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/console/clie
