Re: [Xen-devel] [PATCH v2] xen: stop_machine: fill fn_result only in case of error.

2017-05-31 Thread Wei Liu
On Wed, May 31, 2017 at 12:41:32PM +0200, gregory.herr...@oracle.com wrote: > From: Gregory Herrero > > @@ -150,8 +155,11 @@ static void stopmachine_action(unsigned long cpu) > case STOPMACHINE_INVOKE: > if ( (stopmachine_data.fn_cpu == smp_processor_id()) || >

[Xen-devel] [PATCH v2] xen: stop_machine: fill fn_result only in case of error.

2017-05-31 Thread gregory . herrero
From: Gregory Herrero When stop_machine_run() is called with NR_CPUS as last argument, fn_result member must be filled only if an error happens since it is shared across all cpus. Assume CPU1 detects an error and set fn_result to -1, then CPU2 doesn't detect an error and set fn_result to 0. The