Re: [Xen-devel] [PATCH v2] xen: arm64: more useful logging on bad trap.

2015-02-19 Thread Ian Campbell
On Thu, 2015-02-19 at 10:22 +, Ian Campbell wrote: > > >>> +printk("Bad mode in %s handler detected", handler[reason]); > > >>> +printk("ESR=0x%08"PRIx32": EC=%"PRIx32", IL=%"PRIx32", > > >>> ISS=%"PRIx32"\n", > > >>> + hsr.bits, hsr.ec, hsr.len, hsr.iss); > > >> This would

Re: [Xen-devel] [PATCH v2] xen: arm64: more useful logging on bad trap.

2015-02-19 Thread Ian Campbell
On Thu, 2015-02-19 at 10:17 +, Andrew Cooper wrote: > On 19/02/15 08:45, Ian Campbell wrote: > > On Wed, 2015-02-18 at 17:26 +, Andrew Cooper wrote: > >> On 18/02/15 17:01, Ian Campbell wrote: > >>> Dump the register state before panicing so we have some clue where the > >>> issue occurred.

Re: [Xen-devel] [PATCH v2] xen: arm64: more useful logging on bad trap.

2015-02-19 Thread Andrew Cooper
On 19/02/15 08:45, Ian Campbell wrote: > On Wed, 2015-02-18 at 17:26 +, Andrew Cooper wrote: >> On 18/02/15 17:01, Ian Campbell wrote: >>> Dump the register state before panicing so we have some clue where the >>> issue occurred. Also decode the ESR register a bit to save having to >>> grab a p

Re: [Xen-devel] [PATCH v2] xen: arm64: more useful logging on bad trap.

2015-02-19 Thread Ian Campbell
On Wed, 2015-02-18 at 17:26 +, Andrew Cooper wrote: > On 18/02/15 17:01, Ian Campbell wrote: > > Dump the register state before panicing so we have some clue where the > > issue occurred. Also decode the ESR register a bit to save having to > > grab a pen and paper. > > > > ESR_EL2 is a 32-bit

Re: [Xen-devel] [PATCH v2] xen: arm64: more useful logging on bad trap.

2015-02-18 Thread Andrew Cooper
On 18/02/15 17:01, Ian Campbell wrote: > Dump the register state before panicing so we have some clue where the > issue occurred. Also decode the ESR register a bit to save having to > grab a pen and paper. > > ESR_EL2 is a 32-bit register, so use SYSREG_READ32 not ..._READ64, as > we already do co

[Xen-devel] [PATCH v2] xen: arm64: more useful logging on bad trap.

2015-02-18 Thread Ian Campbell
Dump the register state before panicing so we have some clue where the issue occurred. Also decode the ESR register a bit to save having to grab a pen and paper. ESR_EL2 is a 32-bit register, so use SYSREG_READ32 not ..._READ64, as we already do correctly in the main trap handler. While here noti