On Wed, 22 Jun 2016, Julien Grall wrote:
> Hi Konrad,
>
> On 22/06/16 15:29, Konrad Rzeszutek Wilk wrote:
> > > > Oh, indeed!
> > > > >
> > > > >
> > > > > My patch doesn't change anything regarding the fact that if the magics
> > > > > are
> > > > > not valid (due to quite old kernel version) t
Hi Konrad,
On 22/06/16 15:29, Konrad Rzeszutek Wilk wrote:
Oh, indeed!
My patch doesn't change anything regarding the fact that if the magics are
not valid (due to quite old kernel version) the code does exit with an
error.
/me nods
While the review of v1 of this patch, Julien asked for a
> >>Please check the _existing_ code: It's
> >>
> >>
> >>if ( zimage.magic0 != ZIMAGE64_MAGIC_V0 &&
> >> zimage.magic1 != ZIMAGE64_MAGIC_V1 )
> >> return -EINVAL;
>
> It is an "&&" not "||". So it will fail only if none of the 2 magics are
> present.
>
Argh. Brainfart!
> >Oh, indeed!
> >
On 22.06.2016 15:44, Julien Grall wrote:
Hi Konrad,
On 22/06/16 14:30, Konrad Rzeszutek Wilk wrote:
On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote:
With the Linux kernel commits
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?
Hello,
On 22/06/16 14:51, Konrad Rzeszutek Wilk wrote:
On Wed, Jun 22, 2016 at 03:44:44PM +0200, Dirk Behme wrote:
On 22.06.2016 15:30, Konrad Rzeszutek Wilk wrote:
On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote:
With the Linux kernel commits
https://git.kernel.org/cgit/linux/ker
On Wed, Jun 22, 2016 at 03:44:44PM +0200, Dirk Behme wrote:
> On 22.06.2016 15:30, Konrad Rzeszutek Wilk wrote:
> >On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote:
> >>With the Linux kernel commits
> >>
> >>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentat
On 22.06.2016 15:30, Konrad Rzeszutek Wilk wrote:
On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote:
With the Linux kernel commits
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0
https:/
Hi Konrad,
On 22/06/16 14:30, Konrad Rzeszutek Wilk wrote:
On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote:
With the Linux kernel commits
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c
On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote:
> With the Linux kernel commits
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0
>
> https://git.kernel.org/cgit/linux/kernel/git/torva
With the Linux kernel commits
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=a2c1d73b94ed49
10 matches
Mail list logo
