Re: [Xen-devel] [PATCH v2] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-27 Thread Jan Beulich
>>> On 26.03.15 at 13:40, wrote: > @@ -1447,14 +1452,15 @@ x86_emulate( > unsigned int op_bytes, def_op_bytes, ad_bytes, def_ad_bytes; > bool_t lock_prefix = 0; > int override_seg = -1, rc = X86EMUL_OKAY; > -struct operand src, dst; > +struct operand src = { .reg = REG_POISO

Re: [Xen-devel] [PATCH v2] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-26 Thread Andrew Cooper
On 26/03/15 12:40, Tim Deegan wrote: In the hopes of making any future errors along the lines of XSA-123 into clean crashes instead of memory corruption bugs. Signed-off-by: Tim Deegan CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Reviewed-by: Andrew Cooper --- v2: tweak poison valu

[Xen-devel] [PATCH v2] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-26 Thread Tim Deegan
In the hopes of making any future errors along the lines of XSA-123 into clean crashes instead of memory corruption bugs. Signed-off-by: Tim Deegan CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper --- v2: tweak poison values (Andrew Cooper) --- xen/arch/x86/x86_emulate/x86_emulate.c | 12 +++