Re: [Xen-devel] [PATCH v2] x86: refine debugging of SMEP/SMAP fix

2016-05-17 Thread Andrew Cooper
On 17/05/16 14:35, Jan Beulich wrote: > Instead of just latching cr4_pv32_mask into %rdx, correct the found > wrong value in %cr4 (to avoid triggering another BUG). The value left > in %rdx should be sufficient for deducing cr4_pv32_mask from the > register dump. > > Also there is one more place fo

Re: [Xen-devel] [PATCH v2] x86: refine debugging of SMEP/SMAP fix

2016-05-17 Thread Wei Liu
On Tue, May 17, 2016 at 02:37:16PM +0100, Andrew Cooper wrote: > On 17/05/16 14:35, Jan Beulich wrote: > > Instead of just latching cr4_pv32_mask into %rdx, correct the found > > wrong value in %cr4 (to avoid triggering another BUG). The value left > > in %rdx should be sufficient for deducing cr4_

[Xen-devel] [PATCH v2] x86: refine debugging of SMEP/SMAP fix

2016-05-17 Thread Jan Beulich
Instead of just latching cr4_pv32_mask into %rdx, correct the found wrong value in %cr4 (to avoid triggering another BUG). The value left in %rdx should be sufficient for deducing cr4_pv32_mask from the register dump. Also there is one more place for XEN_CR4_PV32_BITS to be used. Signed-off-by: J