Re: [Xen-devel] [PATCH v2] x86: psr: support co-exist features' values setting

2017-10-10 Thread Roger Pau Monné
On Tue, Oct 10, 2017 at 12:41:40AM +, Yi Sun wrote: > On 17-10-09 15:03:25, Roger Pau Monn� wrote: > > On Sun, Oct 08, 2017 at 04:22:00AM +, Yi Sun wrote: > [...] > > > > static void do_write_psr_msrs(void *data) > > > > Should this be "static int do_write_psr_msrs"... > > > This functio

Re: [Xen-devel] [PATCH v2] x86: psr: support co-exist features' values setting

2017-10-09 Thread Yi Sun
On 17-10-09 15:03:25, Roger Pau Monn� wrote: > On Sun, Oct 08, 2017 at 04:22:00AM +, Yi Sun wrote: [...] > > static void do_write_psr_msrs(void *data) > > Should this be "static int do_write_psr_msrs"... > This function is a parameter of 'on_selected_cpus()' which requires it to be 'void'.

Re: [Xen-devel] [PATCH v2] x86: psr: support co-exist features' values setting

2017-10-09 Thread Roger Pau Monné
On Sun, Oct 08, 2017 at 04:22:00AM +, Yi Sun wrote: > It changes the memebers in 'cos_write_info' to transfer the feature array, > feature properties array and value array. Then, we can write all features > values on the cos id into MSRs. > > Because multiple features may co-exist, we need han

[Xen-devel] [PATCH v2] x86: psr: support co-exist features' values setting

2017-10-07 Thread Yi Sun
It changes the memebers in 'cos_write_info' to transfer the feature array, feature properties array and value array. Then, we can write all features values on the cos id into MSRs. Because multiple features may co-exist, we need handle all features to write values of them into a COS register with