Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-07 Thread Adrian Pop
On Thu, Apr 06, 2017 at 08:09:23AM -0600, Jan Beulich wrote: > >>> On 06.04.17 at 11:37, wrote: > > On Thu, Apr 06, 2017 at 03:20:21AM -0600, Jan Beulich wrote: > >> >>> On 06.04.17 at 10:59, wrote: > >> > On Wed, Apr 05, 2017 at 08:26:27AM -0600, Jan Beulich wrote: > >> >> >>> On 04.04.17 at 11:

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-06 Thread Jan Beulich
>>> On 06.04.17 at 11:37, wrote: > On Thu, Apr 06, 2017 at 03:20:21AM -0600, Jan Beulich wrote: >> >>> On 06.04.17 at 10:59, wrote: >> > On Wed, Apr 05, 2017 at 08:26:27AM -0600, Jan Beulich wrote: >> >> >>> On 04.04.17 at 11:57, wrote: >> >> > --- a/xen/arch/x86/hvm/hvm.c >> >> > +++ b/xen/arch

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-06 Thread Adrian Pop
On Thu, Apr 06, 2017 at 03:20:21AM -0600, Jan Beulich wrote: > >>> On 06.04.17 at 10:59, wrote: > > On Wed, Apr 05, 2017 at 08:26:27AM -0600, Jan Beulich wrote: > >> >>> On 04.04.17 at 11:57, wrote: > >> > --- a/xen/arch/x86/hvm/hvm.c > >> > +++ b/xen/arch/x86/hvm/hvm.c > >> > @@ -3572,6 +3572,43

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-06 Thread Jan Beulich
>>> On 06.04.17 at 10:59, wrote: > On Wed, Apr 05, 2017 at 08:26:27AM -0600, Jan Beulich wrote: >> >>> On 04.04.17 at 11:57, wrote: >> > --- a/xen/arch/x86/hvm/hvm.c >> > +++ b/xen/arch/x86/hvm/hvm.c >> > @@ -3572,6 +3572,43 @@ gp_fault: >> > return X86EMUL_EXCEPTION; >> > } >> > >> > +in

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-06 Thread Adrian Pop
Hello, On Wed, Apr 05, 2017 at 08:26:27AM -0600, Jan Beulich wrote: > >>> On 04.04.17 at 11:57, wrote: > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -3572,6 +3572,43 @@ gp_fault: > > return X86EMUL_EXCEPTION; > > } > > > > +int hvm_descriptor_access_intercept(ui

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-05 Thread Jan Beulich
>>> On 04.04.17 at 11:57, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -3572,6 +3572,43 @@ gp_fault: > return X86EMUL_EXCEPTION; > } > > +int hvm_descriptor_access_intercept(uint64_t exit_info, > +uint64_t vmx_exit_qualificat

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-05 Thread Tian, Kevin
> From: Adrian Pop [mailto:a...@bitdefender.com] > Sent: Tuesday, April 4, 2017 5:58 PM > > Adds monitor support for descriptor access events (reads & writes of > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > Signed-off-by: Adrian Pop Reviewed-by: Kevin Tian _

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-04 Thread Adrian Pop
On Tue, Apr 04, 2017 at 04:26:24PM +0100, Andrew Cooper wrote: > On 04/04/17 10:57, Adrian Pop wrote: > > diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c > > index f5cd245771..d60e4afd0c 100644 > > --- a/xen/arch/x86/hvm/monitor.c > > +++ b/xen/arch/x86/hvm/monitor.c > > @@ -72

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-04 Thread Andrew Cooper
On 04/04/17 10:57, Adrian Pop wrote: > diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c > index f5cd245771..d60e4afd0c 100644 > --- a/xen/arch/x86/hvm/monitor.c > +++ b/xen/arch/x86/hvm/monitor.c > @@ -72,6 +72,28 @@ void hvm_monitor_msr(unsigned int msr, uint64_t value) >

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-04 Thread Adrian Pop
On Tue, Apr 04, 2017 at 09:23:28AM -0400, Boris Ostrovsky wrote: > On 04/04/2017 05:57 AM, Adrian Pop wrote: > > Adds monitor support for descriptor access events (reads & writes of > > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > > > Signed-off-by: Adrian Pop > > > > --- a/xen

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-04 Thread Boris Ostrovsky
On 04/04/2017 05:57 AM, Adrian Pop wrote: > Adds monitor support for descriptor access events (reads & writes of > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > Signed-off-by: Adrian Pop > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -856,6 +856,23 @@

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-04 Thread Adrian Pop
On Tue, Apr 04, 2017 at 01:52:24PM +0300, Razvan Cojocaru wrote: > You've forgotten Wei Liu's ack for the first version of the patch. > > For the vm_event bits: > > Acked-by: Razvan Cojocaru Okay, will include them next time. Thanks! ___ Xen-devel m

Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-04 Thread Razvan Cojocaru
On 04/04/2017 12:57 PM, Adrian Pop wrote: > Adds monitor support for descriptor access events (reads & writes of > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > Signed-off-by: Adrian Pop > --- > changes in v2: > - use two sub-structs (vmx/svm) for vm_event_desc_access (Tamas K >

[Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

2017-04-04 Thread Adrian Pop
Adds monitor support for descriptor access events (reads & writes of IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). Signed-off-by: Adrian Pop --- changes in v2: - use two sub-structs (vmx/svm) for vm_event_desc_access (Tamas K Lengyel) - more compact version of the descriptor VM-Exi