Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Jan Beulich
>>> On 18.01.16 at 17:33, wrote: > El 18/01/16 a les 17.24, Jan Beulich ha escrit: >> ULL might not be supported by pre-C99 compilers. Casting to >> uint64_t is, well, ugly. The flags field really has no business >> being wider then 32 bits. > > Right, although Xen uses gnu99 this is a public hea

Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Roger Pau Monné
El 18/01/16 a les 17.24, Jan Beulich ha escrit: On 18.01.16 at 16:38, wrote: >> El 18/01/16 a les 16.24, Andrew Cooper ha escrit: >>> On 18/01/16 15:21, Jan Beulich wrote: >>> On 18.01.16 at 16:09, wrote: > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/a

Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Jan Beulich
>>> On 18.01.16 at 16:38, wrote: > El 18/01/16 a les 16.24, Andrew Cooper ha escrit: >> On 18/01/16 15:21, Jan Beulich wrote: >> On 18.01.16 at 16:09, wrote: --- a/xen/include/public/arch-x86/hvm/save.h +++ b/xen/include/public/arch-x86/hvm/save.h @@ -161,8 +161,8 @@ struct hvm

Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Roger Pau Monné
El 18/01/16 a les 16.24, Andrew Cooper ha escrit: > On 18/01/16 15:21, Jan Beulich wrote: > On 18.01.16 at 16:09, wrote: >>> --- a/xen/include/public/arch-x86/hvm/save.h >>> +++ b/xen/include/public/arch-x86/hvm/save.h >>> @@ -161,8 +161,8 @@ struct hvm_hw_cpu { >>> uint32_t error_code; >

Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Andrew Cooper
On 18/01/16 15:21, Jan Beulich wrote: On 18.01.16 at 16:09, wrote: >> --- a/xen/include/public/arch-x86/hvm/save.h >> +++ b/xen/include/public/arch-x86/hvm/save.h >> @@ -161,8 +161,8 @@ struct hvm_hw_cpu { >> uint32_t error_code; >> >> #define _XEN_X86_FPU_INITIALISED0 >> -#de

Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Jan Beulich
>>> On 18.01.16 at 16:09, wrote: > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/arch-x86/hvm/save.h > @@ -161,8 +161,8 @@ struct hvm_hw_cpu { > uint32_t error_code; > > #define _XEN_X86_FPU_INITIALISED0 > -#define XEN_X86_FPU_INITIALISED (1U<<_XEN

Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Andrew Cooper
On 18/01/16 15:09, Roger Pau Monne wrote: > So that the size of the structure is the same on 32 and 64bit. > > Signed-off-by: Roger Pau Monné > --- > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Andrew Cooper Reviewed-by: Andrew Cooper _

[Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

2016-01-18 Thread Roger Pau Monne
So that the size of the structure is the same on 32 and 64bit. Signed-off-by: Roger Pau Monné --- Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Andrew Cooper --- This should fix the issues seen on OSSTest when using a 32bit toolstack on a 64bit hypervisor to create a Windows 7 HVM gues