Re: [Xen-devel] [PATCH v2] tools/xenconsoled: Increase file descriptor limit

2015-02-17 Thread Wei Liu
On Tue, Feb 17, 2015 at 05:31:19PM +, Andrew Cooper wrote: > On 17/02/15 16:48, Wei Liu wrote: > > On Tue, Feb 17, 2015 at 04:37:08PM +, Andrew Cooper wrote: > > > >> I am not sure what an admin could usefully do with a logged failure > >> message here. Xenconsoled will most likely not fun

Re: [Xen-devel] [PATCH v2] tools/xenconsoled: Increase file descriptor limit

2015-02-17 Thread Andrew Cooper
On 17/02/15 16:48, Wei Liu wrote: > On Tue, Feb 17, 2015 at 04:37:08PM +, Andrew Cooper wrote: > >> I am not sure what an admin could usefully do with a logged failure >> message here. Xenconsoled will most likely not function in an >> environment where it is not sufficiently privileged to mak

Re: [Xen-devel] [PATCH v2] tools/xenconsoled: Increase file descriptor limit

2015-02-17 Thread Wei Liu
On Tue, Feb 17, 2015 at 04:37:08PM +, Andrew Cooper wrote: [...] > >> + > > This function looks Linux centric (/proc and CAP_SYSRESOURCE). Please be > > considerate to other Unices. :-) > > > > Also you might want to log failures along the line. > > > > Wei. > > setrlimit() is posix. From the

Re: [Xen-devel] [PATCH v2] tools/xenconsoled: Increase file descriptor limit

2015-02-17 Thread Andrew Cooper
On 17/02/15 16:28, Wei Liu wrote: > On Tue, Feb 17, 2015 at 04:21:24PM +, Andrew Cooper wrote: >> XenServer's VM density testing uncovered a regression when moving from >> sysvinit to systemd where the file descriptor limit dropped from 4096 to >> 1024. (XenServer had previously inserted a ulim

Re: [Xen-devel] [PATCH v2] tools/xenconsoled: Increase file descriptor limit

2015-02-17 Thread Wei Liu
On Tue, Feb 17, 2015 at 04:21:24PM +, Andrew Cooper wrote: > XenServer's VM density testing uncovered a regression when moving from > sysvinit to systemd where the file descriptor limit dropped from 4096 to > 1024. (XenServer had previously inserted a ulimit statement into its > initscripts.) >

[Xen-devel] [PATCH v2] tools/xenconsoled: Increase file descriptor limit

2015-02-17 Thread Andrew Cooper
XenServer's VM density testing uncovered a regression when moving from sysvinit to systemd where the file descriptor limit dropped from 4096 to 1024. (XenServer had previously inserted a ulimit statement into its initscripts.) One solution is to use LimitNOFILE=4096 in xenconsoled.service to match