Re: [Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

2017-08-02 Thread George Dunlap
On Mon, Jun 26, 2017 at 3:37 PM, Andrew Cooper wrote: > On 26/06/17 14:00, Andrew Cooper wrote: >> On 26/06/17 13:55, Olaf Hering wrote: >>> If the default compiler silently defaults to to -fPIC/-fPIE building >>> rombios fails: >>> >>> ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o

Re: [Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

2017-06-26 Thread Andrew Cooper
On 26/06/17 14:00, Andrew Cooper wrote: > On 26/06/17 13:55, Olaf Hering wrote: >> If the default compiler silently defaults to to -fPIC/-fPIE building >> rombios fails: >> >> ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o >> 32bitbios_all.o >> There are undefined symbols i

Re: [Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

2017-06-26 Thread Andrew Cooper
On 26/06/17 13:55, Olaf Hering wrote: > If the default compiler silently defaults to to -fPIC/-fPIE building > rombios fails: > > ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o > 32bitbios_all.o > There are undefined symbols in the BIOS: > U _GLOBAL_OFFSET_TABLE_

[Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

2017-06-26 Thread Olaf Hering
If the default compiler silently defaults to to -fPIC/-fPIE building rombios fails: ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o 32bitbios_all.o There are undefined symbols in the BIOS: U _GLOBAL_OFFSET_TABLE_ make[10]: *** [Makefile:26: 32bitbios_all.o] Error