Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Jan Beulich
>>> On 09.01.17 at 17:58, wrote: > Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing > adjustments"): >> Right, I had been thinking of this too, but then wasn't sure to >> suggest such a mixture. Perhaps the first two options could >> even remain completely nameless then (I th

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing adjustments"): > Right, I had been thinking of this too, but then wasn't sure to > suggest such a mixture. Perhaps the first two options could > even remain completely nameless then (I think those are the > ones which had been t

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Jan Beulich
>>> On 09.01.17 at 17:34, wrote: > Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing > adjustments"): >> See e.g. the cpufreq=, i.e. we're talking of >> >> com1=:,:,... > > I think we will have to use `=', so > com1==,=,... > > Since we already have BDFs which I think con

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing adjustments"): > See e.g. the cpufreq=, i.e. we're talking of > > com1=:,:,... I think we will have to use `=', so com1==,=,... Since we already have BDFs which I think contain `:', and that would be more confusing than the

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Jan Beulich
>>> On 09.01.17 at 16:40, wrote: > On 01/09/2017 02:10 AM, Jan Beulich wrote: > > On 06.01.17 at 19:34, wrote: >>> Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing >>> adjustments"): On 06.01.17 at 17:24, wrote: Well, as you may have seen, things are getting c

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Swapnil Paratey
On 01/09/2017 02:10 AM, Jan Beulich wrote: On 06.01.17 at 19:34, wrote: Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing adjustments"): On 06.01.17 at 17:24, wrote: Well, as you may have seen, things are getting complicated here: The two currently-last elements are permi

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Jan Beulich
>>> On 06.01.17 at 19:34, wrote: > Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing > adjustments"): >> On 06.01.17 at 17:24, wrote: >> Well, as you may have seen, things are getting complicated here: >> The two currently-last elements are permitted only with >> CONFIG_HAS_P

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-09 Thread Jan Beulich
>>> On 06.01.17 at 18:28, wrote: > On 01/06/2017 10:43 AM, Jan Beulich wrote: > > On 06.01.17 at 17:24, wrote: >>> On 01/06/2017 08:58 AM, Jan Beulich wrote: >>> On 05.01.17 at 23:39, wrote: > @@ -1118,6 +1118,20 @@ static void __init ns16550_parse_port_config( >uart

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-06 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing adjustments"): > On 06.01.17 at 17:24, wrote: > Well, as you may have seen, things are getting complicated here: > The two currently-last elements are permitted only with > CONFIG_HAS_PCI, so by adding the new fields to the end

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-06 Thread Swapnil Paratey
On 01/06/2017 10:43 AM, Jan Beulich wrote: On 06.01.17 at 17:24, wrote: On 01/06/2017 08:58 AM, Jan Beulich wrote: On 05.01.17 at 23:39, wrote: @@ -1118,6 +1118,20 @@ static void __init ns16550_parse_port_config( uart->clock_hz = simple_strtoul(conf, &conf, 0) << 4; }

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-06 Thread Jan Beulich
>>> On 06.01.17 at 17:24, wrote: > On 01/06/2017 08:58 AM, Jan Beulich wrote: > On 05.01.17 at 23:39, wrote: >>> @@ -1118,6 +1118,20 @@ static void __init ns16550_parse_port_config( >>> uart->clock_hz = simple_strtoul(conf, &conf, 0) << 4; >>> } >>> >>> +if ( *conf == '

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-06 Thread swapnil
On 01/06/2017 08:58 AM, Jan Beulich wrote: On 05.01.17 at 23:39, wrote: @@ -299,6 +299,15 @@ Both option `com1` and `com2` follow the same format. the bootloader or other earlier firmware has already set it up. * Optionally, the base baud rate (usually the highest baud rate the devic

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-06 Thread Jan Beulich
>>> On 05.01.17 at 23:39, wrote: > @@ -299,6 +299,15 @@ Both option `com1` and `com2` follow the same format. >the bootloader or other earlier firmware has already set it up. > * Optionally, the base baud rate (usually the highest baud rate the >device can communicate at) can be specified

[Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-05 Thread Swapnil Paratey
Add parsing options for reg_width and reg_shift in bootup command line parameters. This adds flexibility in setting register values for MMIO UART devices. Increase length of opt_com1 and opt_com2 buffer to accommodate more command line parameters. eg. com1=115200,8n1,0x3f8,4 (legacy IO) eg. com1=

Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments

2017-01-05 Thread Andrew Cooper
On 05/01/17 22:39, Swapnil Paratey wrote: > Add parsing options for reg_width and reg_shift in bootup command line > parameters. This adds flexibility in setting register values > for MMIO UART devices. > > Increase length of opt_com1 and opt_com2 buffer to accommodate more > command line parameter