Re: [Xen-devel] [PATCH v2] libxc: fix memory leak in migration v2

2015-07-27 Thread Ian Campbell
On Sun, 2015-07-26 at 22:36 +0100, Andrew Cooper wrote: > On 26/07/2015 22:34, Wei Liu wrote: > > Originally there was only one counter to keep track of pages. It > was > > used erroneously to keep track of how many pages were mapped and > how > > many pages needed to be sent. In the end munmap(2

Re: [Xen-devel] [PATCH v2] libxc: fix memory leak in migration v2

2015-07-26 Thread Andrew Cooper
On 26/07/2015 22:34, Wei Liu wrote: > Originally there was only one counter to keep track of pages. It was > used erroneously to keep track of how many pages were mapped and how > many pages needed to be sent. In the end munmap(2) always had 0 as the > length argument, which resulted in leaking the

[Xen-devel] [PATCH v2] libxc: fix memory leak in migration v2

2015-07-26 Thread Wei Liu
Originally there was only one counter to keep track of pages. It was used erroneously to keep track of how many pages were mapped and how many pages needed to be sent. In the end munmap(2) always had 0 as the length argument, which resulted in leaking the mapping. This problem was discovered on 32