On Wed, Feb 04, Jan Beulich wrote:
> I also checked Python, and they also seem to have been enabling
> _FORTIFY_SOURCE forever. Consequently, with the previously suggested
> patches not having found acceptance, how about
I'm sure python just carries the CFLAGS used for its build, so that
other py
Jan Beulich writes ("Re: [Xen-devel] [PATCH v2] Fix building error"):
> On 04.02.15 at 16:43, wrote:
> > This is still bad. What if the user explicitly wants to build without
> > optimisation ? That's not unusual. And it's only the combination of
> > -O
>>> On 04.02.15 at 16:43, wrote:
> Jan Beulich writes ("Re: [Xen-devel] [PATCH v2] Fix building error"):
>> On 15.01.15 at 12:26, wrote:
>> > Assuming that the underlying bug is intractible I think the right
>> > answer is for an affec
Jan Beulich writes ("Re: [Xen-devel] [PATCH v2] Fix building error"):
> On 15.01.15 at 12:26, wrote:
> > Assuming that the underlying bug is intractible I think the right
> > answer is for an affected developer to do one of the following, as a
> > workaround: ei
>>> On 15.01.15 at 12:26, wrote:
> Wen Congyang writes ("[PATCH v2] Fix building error"):
>> ifeq ($(debug),y)
>> # Disable optimizations and enable debugging information for macros
>> CFLAGS += -O0 -g3
>> +# _FORTIFY_SOURCE requires compiling with optimization
>> +CFLAGS += -Wp,-U_FORTIFY_SOUR
Hi,
On 19/01/15 15:23, Ian Campbell wrote:
> On Thu, 2015-01-15 at 11:26 +, Ian Jackson wrote:
>> Wen Congyang writes ("[PATCH v2] Fix building error"):
>>> ifeq ($(debug),y)
>>> # Disable optimizations and enable debugging information for macros
>>> CFLAGS += -O0 -g3
>>> +# _FORTIFY_SOURCE
On Mon, Jan 19, Ian Campbell wrote:
> The original patch in <54b73658.6030...@cn.fujitsu.com> (correctly IMHO)
> applied the workaround only to the Python parts of the build
> (tools/{python,pygrub}) whereas this v2 and your suggestion would affect
> all of tools/*. That seems like a reasonable co
On 01/20/2015 06:18 PM, Ian Campbell wrote:
> On Tue, 2015-01-20 at 10:21 +0800, Wen Congyang wrote:
>> On 01/19/2015 11:23 PM, Ian Campbell wrote:
>>> On Thu, 2015-01-15 at 11:26 +, Ian Jackson wrote:
Wen Congyang writes ("[PATCH v2] Fix building error"):
> ifeq ($(debug),y)
> #
On Tue, 2015-01-20 at 10:21 +0800, Wen Congyang wrote:
> On 01/19/2015 11:23 PM, Ian Campbell wrote:
> > On Thu, 2015-01-15 at 11:26 +, Ian Jackson wrote:
> >> Wen Congyang writes ("[PATCH v2] Fix building error"):
> >>> ifeq ($(debug),y)
> >>> # Disable optimizations and enable debugging inf
On 01/19/2015 11:23 PM, Ian Campbell wrote:
> On Thu, 2015-01-15 at 11:26 +, Ian Jackson wrote:
>> Wen Congyang writes ("[PATCH v2] Fix building error"):
>>> ifeq ($(debug),y)
>>> # Disable optimizations and enable debugging information for macros
>>> CFLAGS += -O0 -g3
>>> +# _FORTIFY_SOURCE
On Thu, 2015-01-15 at 11:26 +, Ian Jackson wrote:
> Wen Congyang writes ("[PATCH v2] Fix building error"):
> > ifeq ($(debug),y)
> > # Disable optimizations and enable debugging information for macros
> > CFLAGS += -O0 -g3
> > +# _FORTIFY_SOURCE requires compiling with optimization
> > +CFLA
Wen Congyang writes ("[PATCH v2] Fix building error"):
> ifeq ($(debug),y)
> # Disable optimizations and enable debugging information for macros
> CFLAGS += -O0 -g3
> +# _FORTIFY_SOURCE requires compiling with optimization
> +CFLAGS += -Wp,-U_FORTIFY_SOURCE
I'm not entirely convinced about this
Signed-off-by: Wen Congyang
---
tools/Rules.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 962a743..0a54bf1 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -57,6 +57,8 @@ SHLIB_libxenvchan = -Wl,-rpath-link=$(XEN_LIBVCHAN)
ifeq ($(debug),y)
13 matches
Mail list logo