Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-12-04 Thread Boris Ostrovsky
On 12/04/2014 03:51 AM, Jan Beulich wrote: On 03.12.14 at 21:13, wrote: On 11/27/2014 03:57 AM, Jan Beulich wrote: On 26.11.14 at 15:32, wrote: On 11/25/2014 08:49 AM, Jan Beulich wrote: On 17.11.14 at 00:07, wrote: @@ -244,19 +256,19 @@ void vpmu_initialise(struct vcpu *v) switch

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-12-04 Thread Jan Beulich
>>> On 03.12.14 at 21:13, wrote: > On 11/27/2014 03:57 AM, Jan Beulich wrote: > On 26.11.14 at 15:32, wrote: >>> On 11/25/2014 08:49 AM, Jan Beulich wrote: >>> On 17.11.14 at 00:07, wrote: > @@ -244,19 +256,19 @@ void vpmu_initialise(struct vcpu *v) >switch ( vendor ) >>>

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-12-03 Thread Boris Ostrovsky
On 11/27/2014 03:57 AM, Jan Beulich wrote: On 26.11.14 at 15:32, wrote: On 11/25/2014 08:49 AM, Jan Beulich wrote: On 17.11.14 at 00:07, wrote: @@ -244,19 +256,19 @@ void vpmu_initialise(struct vcpu *v) switch ( vendor ) { case X86_VENDOR_AMD: -if ( svm_vpmu_init

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-11-27 Thread Jan Beulich
>>> On 26.11.14 at 15:32, wrote: > On 11/25/2014 08:49 AM, Jan Beulich wrote: > On 17.11.14 at 00:07, wrote: >>> @@ -244,19 +256,19 @@ void vpmu_initialise(struct vcpu *v) >>> switch ( vendor ) >>> { >>> case X86_VENDOR_AMD: >>> -if ( svm_vpmu_initialise(v, opt_vpmu

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-11-27 Thread Jan Beulich
>>> On 26.11.14 at 15:26, wrote: > On 11/25/2014 08:36 AM, Jan Beulich wrote: >> >>> +static long vpmu_sched_checkin(void *arg) >>> +{ >>> +int cpu = cpumask_next(smp_processor_id(), &cpu_online_map); >> unsigned int. >> >>> +int ret; >>> + >>> +/* Mode change shouldn't take more than

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-11-26 Thread Boris Ostrovsky
On 11/25/2014 08:49 AM, Jan Beulich wrote: On 17.11.14 at 00:07, wrote: @@ -244,19 +256,19 @@ void vpmu_initialise(struct vcpu *v) switch ( vendor ) { case X86_VENDOR_AMD: -if ( svm_vpmu_initialise(v, opt_vpmu_enabled) != 0 ) -opt_vpmu_enabled = 0; +

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-11-26 Thread Boris Ostrovsky
On 11/25/2014 08:36 AM, Jan Beulich wrote: +static long vpmu_sched_checkin(void *arg) +{ +int cpu = cpumask_next(smp_processor_id(), &cpu_online_map); unsigned int. +int ret; + +/* Mode change shouldn't take more than a few (say, 5) seconds. */ +if ( NOW() > vpmu_start_ctxt_

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-11-25 Thread Jan Beulich
>>> On 17.11.14 at 00:07, wrote: > @@ -244,19 +256,19 @@ void vpmu_initialise(struct vcpu *v) > switch ( vendor ) > { > case X86_VENDOR_AMD: > -if ( svm_vpmu_initialise(v, opt_vpmu_enabled) != 0 ) > -opt_vpmu_enabled = 0; > +if ( svm_vpmu_initialise(v) !=

Re: [Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-11-25 Thread Jan Beulich
>>> On 17.11.14 at 00:07, wrote: > @@ -278,3 +290,139 @@ void vpmu_dump(struct vcpu *v) > vpmu->arch_vpmu_ops->arch_vpmu_dump(v); > } > > +static s_time_t vpmu_start_ctxt_switch; Blank line here please. > +static long vpmu_sched_checkin(void *arg) > +{ > +int cpu = cpumask_next(s

[Xen-devel] [PATCH v15 11/21] x86/VPMU: Interface for setting PMU mode and flags

2014-11-16 Thread Boris Ostrovsky
Add runtime interface for setting PMU mode and flags. Three main modes are provided: * XENPMU_MODE_OFF: PMU is not virtualized * XENPMU_MODE_SELF: Guests can access PMU MSRs and receive PMU interrupts. * XENPMU_MODE_HV: Same as XENPMU_MODE_SELF for non-proviledged guests, dom0 can profile itself