Re: [Xen-devel] [PATCH v12 19/26] Introduce COLO mode and refactor relevant function

2016-03-24 Thread Changlong Xie
On 03/24/2016 11:45 PM, Ian Jackson wrote: Changlong Xie writes ("[PATCH v12 19/26] Introduce COLO mode and refactor relevant function"): No functional changes. Thanks, this is quite helpful. Although: +static char *qemu_disk_scsi_drive_string(libxl__gc *gc, const char *pdev_path, +

Re: [Xen-devel] [PATCH v12 19/26] Introduce COLO mode and refactor relevant function

2016-03-24 Thread Ian Jackson
Changlong Xie writes ("[PATCH v12 19/26] Introduce COLO mode and refactor relevant function"): > No functional changes. Thanks, this is quite helpful. Although: > +static char *qemu_disk_scsi_drive_string(libxl__gc *gc, const char > *pdev_path, > + int u

[Xen-devel] [PATCH v12 19/26] Introduce COLO mode and refactor relevant function

2016-03-23 Thread Changlong Xie
No functional changes. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- tools/libxl/libxl_dm.c | 59 +- 1 file changed, 53 insertions(+), 6 deletions(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 4aca38e..22260