Re: [Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Jan Beulich
>>> On 25.11.16 at 12:35, wrote: > So, you mean instead of > /* place holder, remove if changing the structure (C99 6.2.5.20) */ > I put > /* place holder, remove if changing the structure */ Yes. Jan ___ Xen-devel mailing list Xen-devel@li

Re: [Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Oleksandr Andrushchenko
On 11/25/2016 01:30 PM, Jan Beulich wrote: On 25.11.16 at 12:19, wrote: On 11/25/2016 11:18 AM, Jan Beulich wrote: On 25.11.16 at 09:03, wrote: +struct xensnd_close_req { +/* place holder, remove if changing the structure (C89 concern) */ +uint8_t __placeholder; +}; changed __placeh

Re: [Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Jan Beulich
>>> On 25.11.16 at 12:19, wrote: > On 11/25/2016 11:18 AM, Jan Beulich wrote: > On 25.11.16 at 09:03, wrote: >>> +struct xensnd_close_req { >>> +/* place holder, remove if changing the structure (C89 concern) */ >>> +uint8_t __placeholder; >>> +}; > changed __placeholder to placeholde

Re: [Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Oleksandr Andrushchenko
On 11/25/2016 11:18 AM, Jan Beulich wrote: On 25.11.16 at 09:03, wrote: +#ifndef __XEN_PUBLIC_IO_XENSND_H__ +#define __XEN_PUBLIC_IO_XENSND_H__ + +#include +#include Along with the target tree (and hence path) change, these also want to become ""-style #include-s. done +struct xensnd_ope

Re: [Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Oleksandr Andrushchenko
On 11/25/2016 11:21 AM, Jan Beulich wrote: On 25.11.16 at 09:49, wrote: --- /dev/null +++ b/xen/include/public/io/sndif.h @@ -0,0 +1,705 @@ +/** + * sndif.h + * + * Unified sound-device I/O interface for Xen guest OSes.

Re: [Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Jan Beulich
>>> On 25.11.16 at 09:49, wrote: > --- /dev/null > +++ b/xen/include/public/io/sndif.h > @@ -0,0 +1,705 @@ > +/** > + * sndif.h > + * > + * Unified sound-device I/O interface for Xen guest OSes. > + * > + * Permission is h

Re: [Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Jan Beulich
>>> On 25.11.16 at 09:03, wrote: > +#ifndef __XEN_PUBLIC_IO_XENSND_H__ > +#define __XEN_PUBLIC_IO_XENSND_H__ > + > +#include > +#include Along with the target tree (and hence path) change, these also want to become ""-style #include-s. > +struct xensnd_open_req { > +uint32_t pcm_rate; /* i

[Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Oleksandr Grytsov Signed-off-by: Oleksandr Dmytryshyn Signed-off-by: Iurii Konovalenko --- Changes sin

[Xen-devel] [PATCH v11] xen: add para-virtual sound interface header file

2016-11-25 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Oleksandr Grytsov Signed-off-by: Oleksandr Dmytryshyn Signed-off-by: Iurii Konovalenko --- Changes sin