Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Oleksandr Andrushchenko
On 11/25/2016 09:11 AM, Jan Beulich wrote: On 24.11.16 at 18:11, wrote: +struct xensnd_close_req { +}; I'm afraid structures without any members aren't permitted by C89. There are 2 options I see: 1. Remove empty structures 2. Leave them in, but add a comment and add a dummy place holder I

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Oleksandr Andrushchenko
On 11/25/2016 09:14 AM, Jan Beulich wrote: On 24.11.16 at 18:25, wrote: On 24/11/16 17:11, Oleksandr Andrushchenko wrote: That is because we want to be cache line aligned. But this is only accurate to your platform. There is HW available with 128 bytes. For instance on Xen ARM, all the str

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Jan Beulich
>>> On 24.11.16 at 18:25, wrote: > On 24/11/16 17:11, Oleksandr Andrushchenko wrote: >> That is because we want to be cache line aligned. > > But this is only accurate to your platform. There is HW available with > 128 bytes. > > For instance on Xen ARM, all the structures are aligned to 128 by

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Jan Beulich
>>> On 24.11.16 at 18:11, wrote: >> > +struct xensnd_close_req { >>> +}; >> >> I'm afraid structures without any members aren't permitted by C89. >> > There are 2 options I see: > 1. Remove empty structures > 2. Leave them in, but add a comment and add a dummy place holder > I would prefer option

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Oleksandr Andrushchenko
+struct xensnd_close_req { +}; >>> >>> >>> >>> >>> I'm afraid structures without any members aren't permitted by C89. >>> >> There are 2 options I see: >> 1. Remove empty structures >> 2. Leave them in, but add a comment and add a dummy

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Julien Grall
Hi Oleksandr, On 24/11/16 18:04, Oleksandr Andrushchenko wrote: +struct xensnd_close_req { +}; I'm afraid structures without any members aren't permitted by C89. There are 2 options I see: 1. Remove empty structures 2. Leave them in, but add a comment and add a dummy place holder I would p

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Oleksandr Andrushchenko
>> +struct xensnd_close_req { >> +}; > > > > I'm afraid structures without any members aren't permitted by C89. > There are 2 options I see: 1. Remove empty structures 2. Leave them in, but add a comment and add a dummy place holder I would prefer opt

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Julien Grall
Hi Oleksandr, On 24/11/16 17:33, Oleksandr Andrushchenko wrote: +struct xensnd_close_req { +}; I'm afraid structures without any members aren't permitted by C89. There are 2 options I see: 1. Remove empty structures 2. Leave them in, but add a comment and add a dummy place holder I would pr

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Oleksandr Andrushchenko
+struct xensnd_close_req { +}; >>> >>> >>> I'm afraid structures without any members aren't permitted by C89. >>> >> There are 2 options I see: >> 1. Remove empty structures >> 2. Leave them in, but add a comment and add a dummy place holder >> I would prefer option 1 as this way the inte

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Julien Grall
Hi, On 24/11/16 17:11, Oleksandr Andrushchenko wrote: +struct xensnd_close_req { +}; I'm afraid structures without any members aren't permitted by C89. There are 2 options I see: 1. Remove empty structures 2. Leave them in, but add a comment and add a dummy place holder I would prefer option

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Oleksandr Andrushchenko
>> +struct xensnd_close_req { >> +}; > > I'm afraid structures without any members aren't permitted by C89. > There are 2 options I see: 1. Remove empty structures 2. Leave them in, but add a comment and add a dummy place holder I would prefer option 1 as this way the interface seems to be clearer,

Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Jan Beulich
>>> On 24.11.16 at 17:01, wrote: > +struct xensnd_close_req { > +}; I'm afraid structures without any members aren't permitted by C89. > +struct xensnd_request { > + uint8_t raw[64]; > +}; > + > +struct xensnd_response { > + uint8_t raw[64]; > +}; What are these two needed for now? If y

[Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

2016-11-24 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Oleksandr Grytsov Signed-off-by: Oleksandr Dmytryshyn Signed-off-by: Iurii Konovalenko --- Changes sin