Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-12 Thread Wei Liu
On Mon, Jul 11, 2016 at 10:40:17AM -0400, Boris Ostrovsky wrote: > On 07/11/2016 09:41 AM, Wei Liu wrote: > > On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: > >> On 07/11/2016 06:47 AM, Wei Liu wrote: > >>> On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > On

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 09:41 AM, Wei Liu wrote: > On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: >> On 07/11/2016 06:47 AM, Wei Liu wrote: >>> On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: On 07/08/2016 12:07 PM, Wei Liu wrote: > On Fri, Jul 08, 2016 at 10:48:52

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Anthony PERARD
On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: > On 07/11/2016 06:47 AM, Wei Liu wrote: > > On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > >> On 07/08/2016 12:07 PM, Wei Liu wrote: > >>> On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: > On

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Julien Grall
On 11/07/16 14:42, Wei Liu wrote: On Mon, Jul 11, 2016 at 02:39:05PM +0100, Julien Grall wrote: Yes, we do. However, in PVH(v2) case it will be seen next by the guest who will expect the tables to already be in memory. I.e. there is no intermediate Xen component, such as hvmloader, who can loa

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Wei Liu
On Mon, Jul 11, 2016 at 02:39:05PM +0100, Julien Grall wrote: > >Yes, we do. However, in PVH(v2) case it will be seen next by the guest > >who will expect the tables to already be in memory. I.e. there is no > >intermediate Xen component, such as hvmloader, who can load the blobs. > > > >Having sai

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Wei Liu
On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: > On 07/11/2016 06:47 AM, Wei Liu wrote: > > On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > >> On 07/08/2016 12:07 PM, Wei Liu wrote: > >>> On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: > On

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Julien Grall
On 11/07/16 14:33, Boris Ostrovsky wrote: On 07/11/2016 06:47 AM, Wei Liu wrote: On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: On 07/08/2016 12:07 PM, Wei Liu wrote: On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: On 07/08/2016 06:55 AM, Wei Liu wrote: +

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 06:47 AM, Wei Liu wrote: > On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: >> On 07/08/2016 12:07 PM, Wei Liu wrote: >>> On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: On 07/08/2016 06:55 AM, Wei Liu wrote: >> + >> +/* Map page that

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > On 07/08/2016 12:07 PM, Wei Liu wrote: > > On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: > >> On 07/08/2016 06:55 AM, Wei Liu wrote: > + > +/* Map page that will hold RSDP */ > +extent = RSD

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-08 Thread Boris Ostrovsky
On 07/08/2016 12:07 PM, Wei Liu wrote: > On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: >> On 07/08/2016 06:55 AM, Wei Liu wrote: + +/* Map page that will hold RSDP */ +extent = RSDP_ADDRESS >> ctxt.page_shift; +rc = populate_acpi_pages(dom, &extent

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-08 Thread Wei Liu
On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: > On 07/08/2016 06:55 AM, Wei Liu wrote: > > > >> + > >> +/* Map page that will hold RSDP */ > >> +extent = RSDP_ADDRESS >> ctxt.page_shift; > >> +rc = populate_acpi_pages(dom, &extent, 1, &ctxt); > >> +if (rc) { > >>

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-08 Thread Boris Ostrovsky
On 07/08/2016 06:55 AM, Wei Liu wrote: > >> + >> +/* Map page that will hold RSDP */ >> +extent = RSDP_ADDRESS >> ctxt.page_shift; >> +rc = populate_acpi_pages(dom, &extent, 1, &ctxt); >> +if (rc) { >> +LOG(ERROR, "%s: populate_acpi_pages for rsdp failed with %d", >> +

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-08 Thread Wei Liu
On Tue, Jul 05, 2016 at 03:05:19PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > > Changes in v1: > * Move to libxl > * Added populate_acpi_pages() > * Stash location/size of tables in xc_dom_image (to be used in constructing > e820 map) > * Use libxl allocator > * Only

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-07 Thread Jan Beulich
>>> On 07.07.16 at 17:12, wrote: > > On 07/07/16 16:08, Boris Ostrovsky wrote: >> On 07/07/2016 04:38 AM, Jan Beulich wrote: >> On 06.07.16 at 19:33, wrote: On 07/06/2016 01:03 PM, Julien Grall wrote: > > On 06/07/16 17:30, Boris Ostrovsky wrote: >> On 07/06/2016 12:04 PM,

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-07 Thread Julien Grall
On 07/07/16 16:08, Boris Ostrovsky wrote: On 07/07/2016 04:38 AM, Jan Beulich wrote: On 06.07.16 at 19:33, wrote: On 07/06/2016 01:03 PM, Julien Grall wrote: On 06/07/16 17:30, Boris Ostrovsky wrote: On 07/06/2016 12:04 PM, Julien Grall wrote: Hi Boris, On 06/07/16 16:50, Boris Ostrovsk

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-07 Thread Boris Ostrovsky
On 07/07/2016 04:38 AM, Jan Beulich wrote: On 06.07.16 at 19:33, wrote: >> On 07/06/2016 01:03 PM, Julien Grall wrote: >>> >>> On 06/07/16 17:30, Boris Ostrovsky wrote: On 07/06/2016 12:04 PM, Julien Grall wrote: > Hi Boris, > > On 06/07/16 16:50, Boris Ostrovsky wrote: >

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-07 Thread Jan Beulich
>>> On 06.07.16 at 19:33, wrote: > On 07/06/2016 01:03 PM, Julien Grall wrote: >> >> >> On 06/07/16 17:30, Boris Ostrovsky wrote: >>> On 07/06/2016 12:04 PM, Julien Grall wrote: Hi Boris, On 06/07/16 16:50, Boris Ostrovsky wrote: > On 07/06/2016 07:05 AM, Julien Grall wrote: >>>

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 01:03 PM, Julien Grall wrote: > > > On 06/07/16 17:30, Boris Ostrovsky wrote: >> On 07/06/2016 12:04 PM, Julien Grall wrote: >>> Hi Boris, >>> >>> On 06/07/16 16:50, Boris Ostrovsky wrote: On 07/06/2016 07:05 AM, Julien Grall wrote: >> +static int populate_acpi_pages(struct x

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Julien Grall
On 06/07/16 17:30, Boris Ostrovsky wrote: On 07/06/2016 12:04 PM, Julien Grall wrote: Hi Boris, On 06/07/16 16:50, Boris Ostrovsky wrote: On 07/06/2016 07:05 AM, Julien Grall wrote: +static int populate_acpi_pages(struct xc_dom_image *dom, + xen_pfn_t *extents,

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 12:04 PM, Julien Grall wrote: > Hi Boris, > > On 06/07/16 16:50, Boris Ostrovsky wrote: >> On 07/06/2016 07:05 AM, Julien Grall wrote: +static int populate_acpi_pages(struct xc_dom_image *dom, + xen_pfn_t *extents, +

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Julien Grall
Hi Boris, On 06/07/16 16:50, Boris Ostrovsky wrote: On 07/06/2016 07:05 AM, Julien Grall wrote: +static int populate_acpi_pages(struct xc_dom_image *dom, + xen_pfn_t *extents, + unsigned int num_pages, + s

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 07:05 AM, Julien Grall wrote: > (CC Stefano) > > Hi Boris, > > On 05/07/16 20:05, Boris Ostrovsky wrote: >> diff --git a/tools/libxl/libxl_arch.h b/tools/libxl/libxl_arch.h >> index 34a853c..7c6536b 100644 >> --- a/tools/libxl/libxl_arch.h >> +++ b/tools/libxl/libxl_arch.h >> @@ -62,4

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Julien Grall
(CC Stefano) Hi Boris, On 05/07/16 20:05, Boris Ostrovsky wrote: diff --git a/tools/libxl/libxl_arch.h b/tools/libxl/libxl_arch.h index 34a853c..7c6536b 100644 --- a/tools/libxl/libxl_arch.h +++ b/tools/libxl/libxl_arch.h @@ -62,4 +62,7 @@ int libxl__arch_domain_construct_memmap(libxl__gc *gc,

[Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-05 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- Changes in v1: * Move to libxl * Added populate_acpi_pages() * Stash location/size of tables in xc_dom_image (to be used in constructing e820 map) * Use libxl allocator * Only set XEN_X86_EMU_LAPIC flag if 'apic' option is set. * Make acpi_build_tables() return