Re: [Xen-devel] [PATCH v1 2/7] tools/livepatch: Set stdout and stderr unbuffered

2016-12-13 Thread Wei Liu
On Wed, Dec 14, 2016 at 06:44:43AM +, Ross Lagerwall wrote: [...] > > > >And perhaps you should check the return value of setvbuf? > > > > I don't think there's anything that can be done if it fails, so there's not > much point in checking the return value. > This is a fair point. Wei. > -

Re: [Xen-devel] [PATCH v1 2/7] tools/livepatch: Set stdout and stderr unbuffered

2016-12-13 Thread Ross Lagerwall
On 12/12/2016 05:02 PM, Wei Liu wrote: On Mon, Dec 12, 2016 at 04:18:05PM +, Ross Lagerwall wrote: Using both stdout and stderr interleaved without newlines can result in strange output when using line buffered mode (e.g. a terminal) or when fully buffered (e.g. redirected to a file). Set bo

Re: [Xen-devel] [PATCH v1 2/7] tools/livepatch: Set stdout and stderr unbuffered

2016-12-12 Thread Wei Liu
On Mon, Dec 12, 2016 at 04:18:05PM +, Ross Lagerwall wrote: > Using both stdout and stderr interleaved without newlines can result in > strange output when using line buffered mode (e.g. a terminal) or when > fully buffered (e.g. redirected to a file). Set both to unbuffered mode > to fix this.

[Xen-devel] [PATCH v1 2/7] tools/livepatch: Set stdout and stderr unbuffered

2016-12-12 Thread Ross Lagerwall
Using both stdout and stderr interleaved without newlines can result in strange output when using line buffered mode (e.g. a terminal) or when fully buffered (e.g. redirected to a file). Set both to unbuffered mode to fix this. Signed-off-by: Ross Lagerwall --- tools/misc/xen-livepatch.c | 8 +++