Re: [Xen-devel] [PATCH v1 1/3] libelf: Preserve log callback after elf_init

2015-10-05 Thread Konrad Rzeszutek Wilk
On Mon, Oct 05, 2015 at 08:39:49AM -0600, Jan Beulich wrote: > >>> On 05.10.15 at 16:23, wrote: > > On Mon, Oct 05, 2015 at 04:36:43AM -0600, Jan Beulich wrote: > >> >>> On 03.10.15 at 20:39, wrote: > >> > The elf_init function uses the log callback to report > >> > errors. But it also memsets th

Re: [Xen-devel] [PATCH v1 1/3] libelf: Preserve log callback after elf_init

2015-10-05 Thread Jan Beulich
>>> On 05.10.15 at 16:23, wrote: > On Mon, Oct 05, 2015 at 04:36:43AM -0600, Jan Beulich wrote: >> >>> On 03.10.15 at 20:39, wrote: >> > The elf_init function uses the log callback to report >> > errors. But it also memsets the whole structure so the >> > log callback (if set) is wiped out! >> >

Re: [Xen-devel] [PATCH v1 1/3] libelf: Preserve log callback after elf_init

2015-10-05 Thread Konrad Rzeszutek Wilk
On Mon, Oct 05, 2015 at 04:36:43AM -0600, Jan Beulich wrote: > >>> On 03.10.15 at 20:39, wrote: > > The elf_init function uses the log callback to report > > errors. But it also memsets the whole structure so the > > log callback (if set) is wiped out! > > Only if you set it before calling elf_in

Re: [Xen-devel] [PATCH v1 1/3] libelf: Preserve log callback after elf_init

2015-10-05 Thread Jan Beulich
>>> On 03.10.15 at 20:39, wrote: > The elf_init function uses the log callback to report > errors. But it also memsets the whole structure so the > log callback (if set) is wiped out! Only if you set it before calling elf_init(), which - looking at all current in-tree users isn't intended. Jan

[Xen-devel] [PATCH v1 1/3] libelf: Preserve log callback after elf_init

2015-10-03 Thread Konrad Rzeszutek Wilk
The elf_init function uses the log callback to report errors. But it also memsets the whole structure so the log callback (if set) is wiped out! This preserves the log callback function along with its states. Signed-off-by: Konrad Rzeszutek Wilk --- xen/common/libelf/libelf-loader.c | 16 ++