Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-03 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, March 01, 2017 11:40 PM > > >>> On 01.03.17 at 16:23, wrote: > > On Wed, 2017-03-01 at 07:28 -0700, Jan Beulich wrote: > >> > > > On 01.03.17 at 15:22, wrote: > >> > > >> > On Wed, 2017-03-01 at 07:04 -0700, Jan Beulich wrote: > >

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Jan Beulich
>>> On 01.03.17 at 16:23, wrote: > On Wed, 2017-03-01 at 07:28 -0700, Jan Beulich wrote: >> > > > On 01.03.17 at 15:22, wrote: >> > >> > On Wed, 2017-03-01 at 07:04 -0700, Jan Beulich wrote: >> > > > > > On 01.03.17 at 14:44, wrote: >> > > > >> > > > Additionally, it would be painful to return

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Sergey Dyasli
On Wed, 2017-03-01 at 07:28 -0700, Jan Beulich wrote: > > > > On 01.03.17 at 15:22, wrote: > > > > On Wed, 2017-03-01 at 07:04 -0700, Jan Beulich wrote: > > > > > > On 01.03.17 at 14:44, wrote: > > > > > > > > Additionally, it would be painful to return the correct error value > > > > all the w

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Jan Beulich
>>> On 01.03.17 at 15:22, wrote: > On Wed, 2017-03-01 at 07:04 -0700, Jan Beulich wrote: >> > > > On 01.03.17 at 14:44, wrote: >> > Additionally, it would be painful to return the correct error value >> > all the way back to nvmx_handle_vmptrld(). >> >> Surely that's at best relevant in the othe

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Sergey Dyasli
On Wed, 2017-03-01 at 07:04 -0700, Jan Beulich wrote: > > > > On 01.03.17 at 14:44, wrote: > > > > On Wed, 2017-03-01 at 05:55 -0700, Jan Beulich wrote: > > > > > > On 01.03.17 at 10:13, wrote: > > > > > > > > If nested vmcs's address is invalid, virtual_vmcs_enter() will fail > > > > during vm

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Jan Beulich
>>> On 01.03.17 at 14:44, wrote: > On Wed, 2017-03-01 at 05:55 -0700, Jan Beulich wrote: >> > > > On 01.03.17 at 10:13, wrote: >> > >> > If nested vmcs's address is invalid, virtual_vmcs_enter() will fail >> > during vmread/vmwrite: >> > >> > (XEN) Xen BUG at .../git/upstream/xen/xen/include/as

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Sergey Dyasli
On Wed, 2017-03-01 at 05:55 -0700, Jan Beulich wrote: > > > > On 01.03.17 at 10:13, wrote: > > > > If nested vmcs's address is invalid, virtual_vmcs_enter() will fail > > during vmread/vmwrite: > > > > (XEN) Xen BUG at .../git/upstream/xen/xen/include/asm/hvm/vmx/vmx.h:333 > > (XEN) [ Xen-4.

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Jan Beulich
>>> On 01.03.17 at 14:22, wrote: > On 01/03/17 12:55, Jan Beulich wrote: > On 01.03.17 at 10:13, wrote: >>> If nested vmcs's address is invalid, virtual_vmcs_enter() will fail >>> during vmread/vmwrite: >>> >>> (XEN) Xen BUG at .../git/upstream/xen/xen/include/asm/hvm/vmx/vmx.h:333 >>> (XEN)

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Andrew Cooper
On 01/03/17 12:55, Jan Beulich wrote: On 01.03.17 at 10:13, wrote: >> If nested vmcs's address is invalid, virtual_vmcs_enter() will fail >> during vmread/vmwrite: >> >> (XEN) Xen BUG at .../git/upstream/xen/xen/include/asm/hvm/vmx/vmx.h:333 >> (XEN) [ Xen-4.9-unstable x86_64 debug=y

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Jan Beulich
>>> On 01.03.17 at 10:13, wrote: > If nested vmcs's address is invalid, virtual_vmcs_enter() will fail > during vmread/vmwrite: > > (XEN) Xen BUG at .../git/upstream/xen/xen/include/asm/hvm/vmx/vmx.h:333 > (XEN) [ Xen-4.9-unstable x86_64 debug=y Tainted:H ] > (XEN) Xen call trace:

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Andrew Cooper
On 01/03/17 09:13, Sergey Dyasli wrote: > If nested vmcs's address is invalid, virtual_vmcs_enter() will fail > during vmread/vmwrite: > > (XEN) Xen BUG at .../git/upstream/xen/xen/include/asm/hvm/vmx/vmx.h:333 > (XEN) [ Xen-4.9-unstable x86_64 debug=y Tainted:H ] > (XEN) Xen call t

[Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-01 Thread Sergey Dyasli
If nested vmcs's address is invalid, virtual_vmcs_enter() will fail during vmread/vmwrite: (XEN) Xen BUG at .../git/upstream/xen/xen/include/asm/hvm/vmx/vmx.h:333 (XEN) [ Xen-4.9-unstable x86_64 debug=y Tainted:H ] (XEN) Xen call trace: (XEN)[] vmcs.c#arch/x86/hvm/vmx/vmcs.o.un