Re: [Xen-devel] [PATCH v1 06/21] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-26 Thread Olivier Martin
Oops, Monday morning... I actually wanted to check if it was a PCD. And I think it should be a PCD in case we have different build variations that require more or less padding. And it does not explain why this value disappear later on. Maybe a later patch will give me the answer... > -Ori

Re: [Xen-devel] [PATCH v1 06/21] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-26 Thread Ard Biesheuvel
On 26 January 2015 at 11:47, Olivier Martin wrote: > I am a bit lost with this patch. I am looking for the definition of > FDT_PADDING. I cannot find it in the previous patches and in subversion. It is in the first hunk of *this* patch > And it looks like it is going to be removed later on as I

Re: [Xen-devel] [PATCH v1 06/21] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-26 Thread Olivier Martin
I am a bit lost with this patch. I am looking for the definition of FDT_PADDING. I cannot find it in the previous patches and in subversion. And it looks like it is going to be removed later on as I cannot find it anymore in the HEAD of your branch https://git.linaro.org/people/ard.biesheuvel/uefi-

Re: [Xen-devel] [PATCH v1 06/21] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > Our primary user QEMU/mach-virt presents us with a FDT blob padded > to 64 KB with plenty of room to set additional properties. However, > in the general case, we should only add properties after making sure > there is enough room available. > > Contribut

[Xen-devel] [PATCH v1 06/21] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-23 Thread Ard Biesheuvel
Our primary user QEMU/mach-virt presents us with a FDT blob padded to 64 KB with plenty of room to set additional properties. However, in the general case, we should only add properties after making sure there is enough room available. Contributed-under: TianoCore Contribution Agreement 1.0 Signed