Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-03-03 Thread Ian Campbell
On Tue, 2015-03-03 at 11:51 +, Julien Grall wrote: > > On 03/03/2015 11:47, Ian Campbell wrote: > >> I'm not sure to follow here. Do you think MAP_SMALL_PAGES should be > >> defined as WRITE_ALLOC? > > > > Sorry I just meant that: > > +#define PAGE_HYPERVISOR_WC ((DEV_WC) | PTE_P

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-03-03 Thread Julien Grall
On 03/03/2015 11:47, Ian Campbell wrote: I'm not sure to follow here. Do you think MAP_SMALL_PAGES should be defined as WRITE_ALLOC? Sorry I just meant that: +#define PAGE_HYPERVISOR_WC ((DEV_WC) | PTE_PRESENT ) should be just: +#define PAGE_HYPERVISOR_WC (DEV_WC |

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-03-03 Thread Ian Campbell
On Tue, 2015-03-03 at 11:17 +, Julien Grall wrote: > Hi Ian, > > On 03/03/2015 10:27, Ian Campbell wrote: > > On Tue, 2015-03-03 at 13:28 +0530, Vijay Kilari wrote: > >> On Tue, Feb 24, 2015 at 6:29 PM, Julien Grall > >> wrote: > >>> On 24/02/15 10:26, Ian Campbell wrote: > On Tue, 2015

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-03-03 Thread Julien Grall
Hi Ian, On 03/03/2015 10:27, Ian Campbell wrote: On Tue, 2015-03-03 at 13:28 +0530, Vijay Kilari wrote: On Tue, Feb 24, 2015 at 6:29 PM, Julien Grall wrote: On 24/02/15 10:26, Ian Campbell wrote: On Tue, 2015-02-24 at 09:38 +, Julien Grall wrote: Hi Ian, On 24/02/2015 09:31, Ian Campbe

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-03-03 Thread Ian Campbell
On Tue, 2015-03-03 at 13:28 +0530, Vijay Kilari wrote: > On Tue, Feb 24, 2015 at 6:29 PM, Julien Grall wrote: > > On 24/02/15 10:26, Ian Campbell wrote: > >> On Tue, 2015-02-24 at 09:38 +, Julien Grall wrote: > >>> Hi Ian, > >>> > >>> On 24/02/2015 09:31, Ian Campbell wrote: > On Wed, 201

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-03-02 Thread Vijay Kilari
On Tue, Feb 24, 2015 at 6:29 PM, Julien Grall wrote: > On 24/02/15 10:26, Ian Campbell wrote: >> On Tue, 2015-02-24 at 09:38 +, Julien Grall wrote: >>> Hi Ian, >>> >>> On 24/02/2015 09:31, Ian Campbell wrote: On Wed, 2015-02-18 at 13:03 +, Julien Grall wrote: >> +{

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-02-24 Thread Jan Beulich
>>> On 24.02.15 at 14:47, wrote: > lpae_t is an uint64_t and flags an unsigned int, so we will have to > check that any bits we have to modified is effectively living on the > less significant word. Or, upon extraction, fold all flags into something fitting into 32 bits, like we do on x86. Jan

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-02-24 Thread Ian Campbell
On Tue, 2015-02-24 at 12:59 +, Julien Grall wrote: > On 24/02/15 10:26, Ian Campbell wrote: > > On Tue, 2015-02-24 at 09:38 +, Julien Grall wrote: > >> Hi Ian, > >> > >> On 24/02/2015 09:31, Ian Campbell wrote: > >>> On Wed, 2015-02-18 at 13:03 +, Julien Grall wrote: > > +

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-02-18 Thread Julien Grall
Hello Vijay, On 18/02/2015 12:56, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K On x86, for the pages mapped with PAGE_HYPERVISOR attribute non-leaf page tables are allocated with valid pte entries. and with MAP_SMALL_PAGES attribute only non-leaf page tables are allocated with invalid (v

[Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-02-18 Thread vijay . kilari
From: Vijaya Kumar K On x86, for the pages mapped with PAGE_HYPERVISOR attribute non-leaf page tables are allocated with valid pte entries. and with MAP_SMALL_PAGES attribute only non-leaf page tables are allocated with invalid (valid bit set to 0) pte entries. However on arm this is not the case