Re: [Xen-devel] [PATCH for-next v3 10/22] x86/traps: delcare percpu softirq_trap

2017-05-31 Thread Wei Liu
On Wed, May 31, 2017 at 05:46:32AM -0600, Jan Beulich wrote: > >>> On 31.05.17 at 13:35, wrote: > > On Mon, May 29, 2017 at 09:49:47AM -0600, Jan Beulich wrote: > >> >>> On 18.05.17 at 19:09, wrote: > >> > It needs to be non-static when we split PV specific code out. > >> > >> I don't follow her

Re: [Xen-devel] [PATCH for-next v3 10/22] x86/traps: delcare percpu softirq_trap

2017-05-31 Thread Jan Beulich
>>> On 31.05.17 at 13:35, wrote: > On Mon, May 29, 2017 at 09:49:47AM -0600, Jan Beulich wrote: >> >>> On 18.05.17 at 19:09, wrote: >> > It needs to be non-static when we split PV specific code out. >> >> I don't follow here: The variable is used by send_guest_trap() to >> communicate with its h

Re: [Xen-devel] [PATCH for-next v3 10/22] x86/traps: delcare percpu softirq_trap

2017-05-31 Thread Wei Liu
On Mon, May 29, 2017 at 09:49:47AM -0600, Jan Beulich wrote: > >>> On 18.05.17 at 19:09, wrote: > > It needs to be non-static when we split PV specific code out. > > I don't follow here: The variable is used by send_guest_trap() to > communicate with its helper nmi_mce_softirq(). How would you >

Re: [Xen-devel] [PATCH for-next v3 10/22] x86/traps: delcare percpu softirq_trap

2017-05-29 Thread Jan Beulich
>>> On 18.05.17 at 19:09, wrote: > It needs to be non-static when we split PV specific code out. I don't follow here: The variable is used by send_guest_trap() to communicate with its helper nmi_mce_softirq(). How would you move one without the other? The main cleanup potential I see here would b

[Xen-devel] [PATCH for-next v3 10/22] x86/traps: delcare percpu softirq_trap

2017-05-18 Thread Wei Liu
It needs to be non-static when we split PV specific code out. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/traps.c| 2 +- xen/include/asm-x86/traps.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index e