Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Wei Liu
On Wed, Nov 08, 2017 at 04:07:35AM -0700, Jan Beulich wrote: > >>> On 08.11.17 at 09:49, wrote: > > On Wed, Nov 08, 2017 at 01:13:29AM -0700, Jan Beulich wrote: > >> >>> On 26.10.17 at 12:10, wrote: > >> > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: > >> >> On Thu, Oct 26, 20

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 08.11.17 at 09:49, wrote: > On Wed, Nov 08, 2017 at 01:13:29AM -0700, Jan Beulich wrote: >> >>> On 26.10.17 at 12:10, wrote: >> > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: >> >> On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei Liu wrote: >> >> > On Thu, Oct 26, 2017 at

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Roger Pau Monné
On Wed, Nov 08, 2017 at 01:13:29AM -0700, Jan Beulich wrote: > >>> On 26.10.17 at 12:10, wrote: > > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: > >> On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei Liu wrote: > >> > On Thu, Oct 26, 2017 at 10:19:35AM +0100, Roger Pau Monne wrote:

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 11:19, wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -28,10 +28,17 @@ config FRAME_POINTER > maybe slower, but it gives very useful debugging information > in case of any Xen bugs. > > +# Hidden option enabled when either GCOV or LLVM coverage

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 12:10, wrote: > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: >> On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei Liu wrote: >> > On Thu, Oct 26, 2017 at 10:19:35AM +0100, Roger Pau Monne wrote: >> > > config GCOV >> > > bool "Gcov Support" >> > >

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 12:24, wrote: > On 26/10/17 10:19, Roger Pau Monne wrote: >> diff --git a/xen/common/coverage/Makefile b/xen/common/coverage/Makefile >> index 0e0510679e..e4541a1233 100644 >> --- a/xen/common/coverage/Makefile >> +++ b/xen/common/coverage/Makefile >> @@ -1,3 +1,4 @@ >> +ifeq ($

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-10-26 Thread Andrew Cooper
On 26/10/17 10:19, Roger Pau Monne wrote: > diff --git a/xen/common/coverage/Makefile b/xen/common/coverage/Makefile > index 0e0510679e..e4541a1233 100644 > --- a/xen/common/coverage/Makefile > +++ b/xen/common/coverage/Makefile > @@ -1,3 +1,4 @@ > +ifeq ($(CONFIG_GCOV),y) > obj-y += gcov_base.o g

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-10-26 Thread Wei Liu
On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: > On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei Liu wrote: > > On Thu, Oct 26, 2017 at 10:19:35AM +0100, Roger Pau Monne wrote: > > > config GCOV > > > bool "Gcov Support" > > > depends on !LIVEPATCH > > > > && !LLVM_COVERAGE >

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-10-26 Thread Roger Pau Monné
On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei Liu wrote: > On Thu, Oct 26, 2017 at 10:19:35AM +0100, Roger Pau Monne wrote: > > config GCOV > > bool "Gcov Support" > > depends on !LIVEPATCH > > && !LLVM_COVERAGE That was my idea, but sadly that's not possible because you generate a circu

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-10-26 Thread Wei Liu
On Thu, Oct 26, 2017 at 10:19:35AM +0100, Roger Pau Monne wrote: > config GCOV > bool "Gcov Support" > depends on !LIVEPATCH && !LLVM_COVERAGE (will review in detail later) ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.x

[Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-10-26 Thread Roger Pau Monne
Just add the Kconfig option and modify the makefiles so the llvm coverage specific code can be added in a follow up patch. Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan