Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-24 Thread Jan Beulich
>>> On 10.04.17 at 15:27, wrote: > No functional change. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Wei Liu
On Mon, Apr 10, 2017 at 04:16:12PM +0100, Andrew Cooper wrote: > On 10/04/17 16:12, Wei Liu wrote: > > On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: > >> On 10/04/17 14:27, Wei Liu wrote: > >>> No functional change. > >>> > >>> Signed-off-by: Wei Liu > >> Throughout this series, p

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Wei Liu
On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: > On 10/04/17 14:27, Wei Liu wrote: > > No functional change. > > > > Signed-off-by: Wei Liu > > Throughout this series, please make sure you add in proper NULL'ing of > freed data. > > While this patch is no functional change at the

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Andrew Cooper
On 10/04/17 16:22, Wei Liu wrote: > On Mon, Apr 10, 2017 at 04:16:12PM +0100, Andrew Cooper wrote: >> On 10/04/17 16:12, Wei Liu wrote: >>> On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: On 10/04/17 14:27, Wei Liu wrote: > No functional change. > > Signed-off-by: We

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Andrew Cooper
On 10/04/17 16:12, Wei Liu wrote: > On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: >> On 10/04/17 14:27, Wei Liu wrote: >>> No functional change. >>> >>> Signed-off-by: Wei Liu >> Throughout this series, please make sure you add in proper NULL'ing of >> freed data. >> >> While this

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Andrew Cooper
On 10/04/17 14:27, Wei Liu wrote: > No functional change. > > Signed-off-by: Wei Liu Throughout this series, please make sure you add in proper NULL'ing of freed data. While this patch is no functional change at the moment, you have introduced a latent double-free bug for if (/when) pv_domain_de

[Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index af060d8239..05885a103d 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @