Re: [Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

2017-04-11 Thread Roger Pau Monne
On Tue, Apr 11, 2017 at 12:21:23AM -0600, Jan Beulich wrote: > >>> On 10.04.17 at 18:46, wrote: > > I have a (I think) less intrusive fix, which relies on using _Pragma, pasted > > below. Let me know what you think, and I can formally submit it. > > Personally I like this much better as a workaro

Re: [Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 18:46, wrote: > I have a (I think) less intrusive fix, which relies on using _Pragma, pasted > below. Let me know what you think, and I can formally submit it. Personally I like this much better as a workaround, provided the omitted warning isn't just cosmetic (i.e. the generat

Re: [Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

2017-04-10 Thread Roger Pau Monne
On Mon, Apr 10, 2017 at 09:19:52AM -0600, Jan Beulich wrote: > >>> On 10.04.17 at 15:34, wrote: > > --- a/xen/include/asm-x86/atomic.h > > +++ b/xen/include/asm-x86/atomic.h > > @@ -41,20 +41,42 @@ build_add_sized(add_u64_sized, "q", uint64_t, "ri") > > #undef build_write_atomic > > #undef build

Re: [Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 15:34, wrote: > --- a/xen/include/asm-x86/atomic.h > +++ b/xen/include/asm-x86/atomic.h > @@ -41,20 +41,42 @@ build_add_sized(add_u64_sized, "q", uint64_t, "ri") > #undef build_write_atomic > #undef build_add_sized > > -void __bad_atomic_size(void); > +/* > + * NB: read_atom

[Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

2017-04-10 Thread Roger Pau Monne
The current code in dm_op breaks clang build with: dm.c:411:21: error: 'break' is bound to loop, GCC binds it to switch [-Werror,-Wgcc-compat] while ( read_atomic(&p2m->ioreq.entry_count) && ^ xen/include/asm/atomic.h:53:43: note: expanded from macro 'read_atomic'