Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-06-01 Thread Andrew Cooper
On 01/06/17 18:25, Julien Grall wrote: > CC Ian + Wei for the testing > > On 01/06/17 12:21, Jan Beulich wrote: > On 01.06.17 at 13:18, wrote: >>> Hi Jan, >>> >>> On 01/06/17 12:15, Jan Beulich wrote: >>> On 01.06.17 at 13:09, wrote: > Hi Andrew, > > On 31/05/17 14:23, Andrew

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-06-01 Thread Julien Grall
CC Ian + Wei for the testing On 01/06/17 12:21, Jan Beulich wrote: On 01.06.17 at 13:18, wrote: Hi Jan, On 01/06/17 12:15, Jan Beulich wrote: On 01.06.17 at 13:09, wrote: Hi Andrew, On 31/05/17 14:23, Andrew Cooper wrote: On 31/05/17 09:52, Julien Grall wrote: Hi, On 05/22/2017 02:32 P

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-06-01 Thread Jan Beulich
>>> On 01.06.17 at 13:18, wrote: > Hi Jan, > > On 01/06/17 12:15, Jan Beulich wrote: > On 01.06.17 at 13:09, wrote: >>> Hi Andrew, >>> >>> On 31/05/17 14:23, Andrew Cooper wrote: On 31/05/17 09:52, Julien Grall wrote: > Hi, > > On 05/22/2017 02:32 PM, Jan Beulich wrote:

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-06-01 Thread Julien Grall
Hi Jan, On 01/06/17 12:15, Jan Beulich wrote: On 01.06.17 at 13:09, wrote: Hi Andrew, On 31/05/17 14:23, Andrew Cooper wrote: On 31/05/17 09:52, Julien Grall wrote: Hi, On 05/22/2017 02:32 PM, Jan Beulich wrote: On 22.05.17 at 15:12, wrote: _PAGE_GNTTAB is only used in debug builds of X

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-06-01 Thread Jan Beulich
>>> On 01.06.17 at 13:09, wrote: > Hi Andrew, > > On 31/05/17 14:23, Andrew Cooper wrote: >> On 31/05/17 09:52, Julien Grall wrote: >>> Hi, >>> >>> On 05/22/2017 02:32 PM, Jan Beulich wrote: >>> On 22.05.17 at 15:12, wrote: > _PAGE_GNTTAB is only used in debug builds of Xen; in release b

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-06-01 Thread Julien Grall
Hi Andrew, On 31/05/17 14:23, Andrew Cooper wrote: On 31/05/17 09:52, Julien Grall wrote: Hi, On 05/22/2017 02:32 PM, Jan Beulich wrote: On 22.05.17 at 15:12, wrote: _PAGE_GNTTAB is only used in debug builds of Xen; in release builds, it has the value 0. Coverity complains that "l1e_get_fl

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-05-31 Thread Andrew Cooper
On 31/05/17 09:52, Julien Grall wrote: > Hi, > > On 05/22/2017 02:32 PM, Jan Beulich wrote: > On 22.05.17 at 15:12, wrote: >>> _PAGE_GNTTAB is only used in debug builds of Xen; in release builds, >>> it has >>> the value 0. Coverity complains that "l1e_get_flags(l1e) & 0" is >>> logically >>>

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-05-31 Thread Julien Grall
Hi, On 05/22/2017 02:32 PM, Jan Beulich wrote: On 22.05.17 at 15:12, wrote: _PAGE_GNTTAB is only used in debug builds of Xen; in release builds, it has the value 0. Coverity complains that "l1e_get_flags(l1e) & 0" is logically dead. Add an extra condition into the logic to skip the flag chec

Re: [Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-05-22 Thread Jan Beulich
>>> On 22.05.17 at 15:12, wrote: > _PAGE_GNTTAB is only used in debug builds of Xen; in release builds, it has > the value 0. Coverity complains that "l1e_get_flags(l1e) & 0" is logically > dead. > > Add an extra condition into the logic to skip the flag check if _PAGE_GNTTAB > is 0. And this h

[Xen-devel] [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning

2017-05-22 Thread Andrew Cooper
_PAGE_GNTTAB is only used in debug builds of Xen; in release builds, it has the value 0. Coverity complains that "l1e_get_flags(l1e) & 0" is logically dead. Add an extra condition into the logic to skip the flag check if _PAGE_GNTTAB is 0. No functional change. Coverity-ID: 1362036 Signed-off-b