Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Andrew Cooper
On 01/11/16 16:56, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH for-4.8 2/2] Config.mk: fix comment for debug > option"): >> On Mon, Oct 31, 2016 at 05:09:46PM +, Wei Liu wrote: >>> -# A debug build of Xen and tools? >>> +# A debug build of tools? >> For this to hold true, a patch like thi

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Wei Liu
On Tue, Nov 01, 2016 at 10:42:37AM -0600, Jan Beulich wrote: > >>> Wei Liu 11/01/16 5:38 PM >>> > >On Tue, Nov 01, 2016 at 10:33:54AM -0600, Jan Beulich wrote: > >> >>> Wei Liu 11/01/16 5:20 PM >>> > >> >On Tue, Nov 01, 2016 at 10:18:46AM -0600, Jan Beulich wrote: > >> >> >>> Wei Liu 11/01/16 2:

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH for-4.8 2/2] Config.mk: fix comment for debug option"): > On Mon, Oct 31, 2016 at 05:09:46PM +, Wei Liu wrote: > > -# A debug build of Xen and tools? > > +# A debug build of tools? > > For this to hold true, a patch like this is needed: > > Please let me know what

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Jan Beulich
>>> Wei Liu 11/01/16 5:38 PM >>> >On Tue, Nov 01, 2016 at 10:33:54AM -0600, Jan Beulich wrote: >> >>> Wei Liu 11/01/16 5:20 PM >>> >> >On Tue, Nov 01, 2016 at 10:18:46AM -0600, Jan Beulich wrote: >> >> >>> Wei Liu 11/01/16 2:48 PM >>> >> >> >config/StdGNU.mk | 8 >> >> >config/SunOS.mk

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Wei Liu
On Tue, Nov 01, 2016 at 10:33:54AM -0600, Jan Beulich wrote: > >>> Wei Liu 11/01/16 5:20 PM >>> > >On Tue, Nov 01, 2016 at 10:18:46AM -0600, Jan Beulich wrote: > >> >>> Wei Liu 11/01/16 2:48 PM >>> > >> >config/StdGNU.mk | 8 > >> >config/SunOS.mk | 7 --- > >> >tools/Rules.mk | 4 +

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Jan Beulich
>>> Wei Liu 11/01/16 5:20 PM >>> >On Tue, Nov 01, 2016 at 10:18:46AM -0600, Jan Beulich wrote: >> >>> Wei Liu 11/01/16 2:48 PM >>> >> >config/StdGNU.mk | 8 >> >config/SunOS.mk | 7 --- >> >tools/Rules.mk | 4 +++- >> >xen/Rules.mk | 6 ++ >> >4 files changed, 9 insertions(+),

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Wei Liu
On Tue, Nov 01, 2016 at 10:18:46AM -0600, Jan Beulich wrote: > >>> Wei Liu 11/01/16 2:48 PM >>> > >config/StdGNU.mk | 8 > >config/SunOS.mk | 7 --- > >tools/Rules.mk | 4 +++- > >xen/Rules.mk | 6 ++ > >4 files changed, 9 insertions(+), 16 deletions(-) > > Considering this di

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Jan Beulich
>>> Wei Liu 11/01/16 2:48 PM >>> >config/StdGNU.mk | 8 >config/SunOS.mk | 7 --- >tools/Rules.mk | 4 +++- >xen/Rules.mk | 6 ++ >4 files changed, 9 insertions(+), 16 deletions(-) Considering this diffstat - did the original global settings not get inherited by any of the oth

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Wei Liu
On Tue, Nov 01, 2016 at 02:58:22PM +, Andrew Cooper wrote: > On 01/11/16 13:47, Wei Liu wrote: > > On Mon, Oct 31, 2016 at 05:09:46PM +, Wei Liu wrote: > >> Signed-off-by: Wei Liu > >> --- > >> Cc: Andrew Cooper > >> Cc: George Dunlap > >> Cc: Ian Jackson > >> Cc: Jan Beulich > >> Cc:

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Andrew Cooper
On 01/11/16 13:47, Wei Liu wrote: > On Mon, Oct 31, 2016 at 05:09:46PM +, Wei Liu wrote: >> Signed-off-by: Wei Liu >> --- >> Cc: Andrew Cooper >> Cc: George Dunlap >> Cc: Ian Jackson >> Cc: Jan Beulich >> Cc: Konrad Rzeszutek Wilk >> Cc: Stefano Stabellini >> Cc: Tim Deegan >> Cc: Wei L

Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-11-01 Thread Wei Liu
On Mon, Oct 31, 2016 at 05:09:46PM +, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Konrad Rzeszutek Wilk > Cc: Stefano Stabellini > Cc: Tim Deegan > Cc: Wei Liu > --- > Config.mk | 3 ++- > 1 file chang

[Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

2016-10-31 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- Config.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index ebbd9c