Re: [Xen-devel] [PATCH for-4.8] x86/cpu: Reposition stack alignment check

2016-11-28 Thread Jan Beulich
>>> On 25.11.16 at 20:04, wrote: > @@ -672,6 +667,15 @@ void load_system_tables(void) > asm volatile ("lidt %0" : : "m" (idtr) ); > asm volatile ("ltr %w0" : : "rm" (TSS_ENTRY << 3) ); > asm volatile ("lldt %w0" : : "rm" (0) ); > + > + /* > + * Bottom-of-stack must

Re: [Xen-devel] [PATCH for-4.8] x86/cpu: Reposition stack alignment check

2016-11-28 Thread Jan Beulich
>>> On 25.11.16 at 20:04, wrote: > As identified during review, using BUG_ON() before `lidt` will result in a > triple fault, even on APs. Oh, I did commit v1 instead of v2, sorry. > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich ___ Xen-de

Re: [Xen-devel] [PATCH for-4.8] x86/cpu: Reposition stack alignment check

2016-11-27 Thread Wei Liu
On Fri, Nov 25, 2016 at 07:04:51PM +, Andrew Cooper wrote: > As identified during review, using BUG_ON() before `lidt` will result in a > triple fault, even on APs. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu On the basis that this is a critical bug fix: Release

[Xen-devel] [PATCH for-4.8] x86/cpu: Reposition stack alignment check

2016-11-25 Thread Andrew Cooper
As identified during review, using BUG_ON() before `lidt` will result in a triple fault, even on APs. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/arch/x86/cpu/common.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/cpu/c