Re: [Xen-devel] [PATCH for-4.7] xl: use xstrdup in cpurange_parse

2016-05-25 Thread Wei Liu
On Wed, May 25, 2016 at 02:23:56PM +0100, Wei Liu wrote: > This ensures buf is always valid when it is passed to strtok_r. > > CID: 1291936 > > Signed-off-by: Wei Liu Pushed. Thanks everyone. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://

Re: [Xen-devel] [PATCH for-4.7] xl: use xstrdup in cpurange_parse

2016-05-25 Thread Wei Liu
On Wed, May 25, 2016 at 02:33:41PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH for-4.7] xl: use xstrdup in cpurange_parse"): > > This ensures buf is always valid when it is passed to strtok_r. > > > > CID: 1291936 > > > > Signed-off-by: Wei Liu > > Acked-by: Ian Jackson > > > This is

Re: [Xen-devel] [PATCH for-4.7] xl: use xstrdup in cpurange_parse

2016-05-25 Thread Ian Jackson
Wei Liu writes ("[PATCH for-4.7] xl: use xstrdup in cpurange_parse"): > This ensures buf is always valid when it is passed to strtok_r. > > CID: 1291936 > > Signed-off-by: Wei Liu Acked-by: Ian Jackson > This is a backport candidate. Really ? malloc failing is vanishingly rare in practice n

Re: [Xen-devel] [PATCH for-4.7] xl: use xstrdup in cpurange_parse

2016-05-25 Thread Andrew Cooper
On 25/05/16 14:23, Wei Liu wrote: > This ensures buf is always valid when it is passed to strtok_r. > > CID: 1291936 > > Signed-off-by: Wei Liu > --- > Cc: Ian Jackson Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org http

[Xen-devel] [PATCH for-4.7] xl: use xstrdup in cpurange_parse

2016-05-25 Thread Wei Liu
This ensures buf is always valid when it is passed to strtok_r. CID: 1291936 Signed-off-by: Wei Liu --- Cc: Ian Jackson This is a backport candidate. --- tools/libxl/xl_cmdimpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdi