Re: [Xen-devel] [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-12-04 Thread Ian Campbell
On Tue, 2014-12-02 at 10:09 -0500, Konrad Rzeszutek Wilk wrote: > > At this point in a freeze I'm much happier with: > > > > tools/pygrub/src/pygrub |4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > The same here. This is now the season of handing out band-aids. > > As such

Re: [Xen-devel] [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-12-02 Thread Konrad Rzeszutek Wilk
On Tue, Dec 02, 2014 at 02:02:58PM +, Ian Campbell wrote: > On Tue, 2014-12-02 at 02:43 +, Andrew Cooper wrote: > > On 01/12/2014 20:30, Konrad Rzeszutek Wilk wrote: > > > On Fri, Nov 28, 2014 at 11:31:24AM +, Ian Campbell wrote: > > >> On Tue, 2014-11-25 at 11:11 -0500, Boris Ostrovsky

Re: [Xen-devel] [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-12-02 Thread Ian Campbell
On Tue, 2014-12-02 at 02:43 +, Andrew Cooper wrote: > On 01/12/2014 20:30, Konrad Rzeszutek Wilk wrote: > > On Fri, Nov 28, 2014 at 11:31:24AM +, Ian Campbell wrote: > >> On Tue, 2014-11-25 at 11:11 -0500, Boris Ostrovsky wrote: > >>> c/s d1b93ea causes substantial functional regressions in

Re: [Xen-devel] [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-12-01 Thread Andrew Cooper
On 01/12/2014 20:30, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 28, 2014 at 11:31:24AM +, Ian Campbell wrote: >> On Tue, 2014-11-25 at 11:11 -0500, Boris Ostrovsky wrote: >>> c/s d1b93ea causes substantial functional regressions in pygrub's ability to >>> parse bootloader configuration files. >

Re: [Xen-devel] [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-12-01 Thread Konrad Rzeszutek Wilk
On Fri, Nov 28, 2014 at 11:31:24AM +, Ian Campbell wrote: > On Tue, 2014-11-25 at 11:11 -0500, Boris Ostrovsky wrote: > > c/s d1b93ea causes substantial functional regressions in pygrub's ability to > > parse bootloader configuration files. > > > > c/s d1b93ea itself changed an an interface wh

Re: [Xen-devel] [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-11-28 Thread Ian Campbell
On Tue, 2014-11-25 at 11:11 -0500, Boris Ostrovsky wrote: > c/s d1b93ea causes substantial functional regressions in pygrub's ability to > parse bootloader configuration files. > > c/s d1b93ea itself changed an an interface which previously used exclusively > integers, to using strings in the case

[Xen-devel] [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-11-25 Thread Boris Ostrovsky
c/s d1b93ea causes substantial functional regressions in pygrub's ability to parse bootloader configuration files. c/s d1b93ea itself changed an an interface which previously used exclusively integers, to using strings in the case of a grub configuration with explicit default set, along with chang