Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-14 Thread Ian Campbell
On Wed, 2014-11-12 at 10:16 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 12, 2014 at 10:56:24AM +, Ian Campbell wrote: > > On Wed, 2014-11-12 at 10:39 +, Wei Liu wrote: > > > ... otherwise when device add operation fails, the error message looks > > > like "libxl: error: libxl.c:1897:d

Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-14 Thread Ian Campbell
On Fri, 2014-11-14 at 10:35 +, Ian Campbell wrote: > On Wed, 2014-11-12 at 10:56 +, Ian Campbell wrote: > > On Wed, 2014-11-12 at 10:39 +, Wei Liu wrote: > > > ... otherwise when device add operation fails, the error message looks > > > like "libxl: error: libxl.c:1897:device_addrm_aoco

Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-14 Thread Ian Campbell
On Wed, 2014-11-12 at 10:56 +, Ian Campbell wrote: > On Wed, 2014-11-12 at 10:39 +, Wei Liu wrote: > > ... otherwise when device add operation fails, the error message looks > > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null) > > device", which is not very helpful

Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-12 Thread Konrad Rzeszutek Wilk
On Wed, Nov 12, 2014 at 10:56:24AM +, Ian Campbell wrote: > On Wed, 2014-11-12 at 10:39 +, Wei Liu wrote: > > ... otherwise when device add operation fails, the error message looks > > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null) > > device", which is not very

Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-12 Thread Wei Liu
And of course this is v2 of this patch. Sorry for not having added that in the subject line. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-12 Thread Ian Campbell
On Wed, 2014-11-12 at 10:39 +, Wei Liu wrote: > ... otherwise when device add operation fails, the error message looks > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null) > device", which is not very helpful. Thanks. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell

[Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-12 Thread Wei Liu
... otherwise when device add operation fails, the error message looks like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null) device", which is not very helpful. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson --- tools/libxl/libxl.c |1 + 1 file changed, 1 inse

Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-12 Thread Wei Liu
On Wed, Nov 12, 2014 at 10:01:24AM +, Ian Campbell wrote: > On Tue, 2014-11-11 at 13:46 +, Wei Liu wrote: > > Signed-off-by: Wei Liu > > Cc: Ian Campbell > > Cc: Ian Jackson > > Cc: George Dunlap > > Cc: Konrad Wilk > > --- > > This is a simple enough bug fix I think it should just go

Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-12 Thread Ian Campbell
On Tue, 2014-11-11 at 13:46 +, Wei Liu wrote: > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson > Cc: George Dunlap > Cc: Konrad Wilk > --- > This is a simple enough bug fix I think it should just go in. Probably, but can you explain in the commit log what the symptoms of not

[Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

2014-11-11 Thread Wei Liu
Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: George Dunlap Cc: Konrad Wilk --- This is a simple enough bug fix I think it should just go in. --- tools/libxl/libxl.c |1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index f7961f6..d