Re: [Xen-devel] [PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove [and 1 more messages]

2015-01-05 Thread Ian Jackson
> Acked-by: Ian Campbell > RElease-Acked-by: Konrad Rzeszutek Wilk Pushed, thanks. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove

2015-01-05 Thread Konrad Rzeszutek Wilk
On Mon, Jan 05, 2015 at 04:34:36PM +, Ian Jackson wrote: > From: Ian Jackson > > do_pci_remove contained this: > > if (type == LIBXL_DOMAIN_TYPE_HVM) { >[stuff] > } else if (type != LIBXL_DOMAIN_TYPE_PV) > abort(); > { > > This is bizarre, and not correct. The e

Re: [Xen-devel] [PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove

2015-01-05 Thread Ian Campbell
On Mon, 2015-01-05 at 16:34 +, Ian Jackson wrote: > From: Ian Jackson > > do_pci_remove contained this: > > if (type == LIBXL_DOMAIN_TYPE_HVM) { >[stuff] > } else if (type != LIBXL_DOMAIN_TYPE_PV) > abort(); > { > > This is bizarre, and not correct. The effect i

[Xen-devel] [PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove

2015-01-05 Thread Ian Jackson
From: Ian Jackson do_pci_remove contained this: if (type == LIBXL_DOMAIN_TYPE_HVM) { [stuff] } else if (type != LIBXL_DOMAIN_TYPE_PV) abort(); { This is bizarre, and not correct. The effect is that HVM guests end up running both the proper code and that intended for