Re: [Xen-devel] [PATCH XTF v3] Implement pv_read_some

2017-07-21 Thread Andrew Cooper
On 21/07/17 08:01, Felix Schmoll wrote: Much better. Just one final question. Do you intend this function to block until data becomes available? (because that appears to be how it behaves.) Yes. I could split it up into two functions if that bothers you. Or do you just want me

Re: [Xen-devel] [PATCH XTF v3] Implement pv_read_some

2017-07-21 Thread Felix Schmoll
> > > Much better. Just one final question. Do you intend this function to > block until data becomes available? (because that appears to be how it > behaves.) > > Yes. I could split it up into two functions if that bothers you. Or do you just want me to include that in the comment?

Re: [Xen-devel] [PATCH XTF v3] Implement pv_read_some

2017-07-20 Thread Andrew Cooper
On 20/07/17 09:09, Felix Schmoll wrote: Implement reading from PV console. Making use of polling. Signed-off-by: Felix Schmoll --- Changed since v2: * Change function name from pv_read to pv_read_some * Add comment to function name * Remove unnecessary code --- common/console.c |

[Xen-devel] [PATCH XTF v3] Implement pv_read_some

2017-07-20 Thread Felix Schmoll
Implement reading from PV console. Making use of polling. Signed-off-by: Felix Schmoll --- Changed since v2: * Change function name from pv_read to pv_read_some * Add comment to function name * Remove unnecessary code --- common/console.c | 24 include/xtf/conso