Re: [Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

2015-03-12 Thread Tamas Lengyel
On Thu, Mar 12, 2015 at 1:13 PM, Tim Deegan wrote: > At 01:11 +0100 on 18 Feb (1424218291), Tamas K Lengyel wrote: > > +struct mem_event_mem_access { > > uint64_t gfn; > > uint64_t offset; > > -uint64_t gla; /* if gla_valid */ > > +uint64_t gla; /* if flags has MEM_ACCESS_GLA_

Re: [Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

2015-03-12 Thread Tim Deegan
At 01:11 +0100 on 18 Feb (1424218291), Tamas K Lengyel wrote: > +struct mem_event_mem_access { > uint64_t gfn; > uint64_t offset; > -uint64_t gla; /* if gla_valid */ > +uint64_t gla; /* if flags has MEM_ACCESS_GLA_VALID set */ > +uint32_t flags; /* MEM_ACCESS_* */ > +uin

Re: [Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

2015-03-11 Thread Ian Campbell
On Wed, 2015-02-18 at 01:11 +0100, Tamas K Lengyel wrote: > tools/tests/xen-access/xen-access.c | 43 + > tools/xenpaging/xenpaging.c | 49 ++- These bits: Acked-by: Ian Campbell (I only glanced at them, I assume they are mechanical in nature) __

[Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-17 Thread Tamas K Lengyel
The public mem_event structures used to communicate with helper applications via shared rings have been used in different settings. However, the variable names within this structure have not reflected this fact, resulting in the reuse of variables to mean different things under different scenarios.