Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-23 Thread Chun Yan Liu
>>> On 6/23/2015 at 07:29 PM, in message <558942ff.5060...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/23/2015 11:18 AM, Chun Yan Liu wrote: > On 6/16/2015 at 01:47 AM, in message <557f0fa7.2060...@eu.citrix.com>, > George > > Dunlap wrote: > >>> +static int libxl__device_us

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-23 Thread George Dunlap
On 06/23/2015 11:18 AM, Chun Yan Liu wrote: On 6/16/2015 at 01:47 AM, in message <557f0fa7.2060...@eu.citrix.com>, George > Dunlap wrote: >>> +static int libxl__device_usb_setdefault(libxl__gc *gc, uint32_t domid, >>> +libxl_device_usb *usb, >>

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-23 Thread Chun Yan Liu
>>> On 6/16/2015 at 01:47 AM, in message <557f0fa7.2060...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/10/2015 04:20 AM, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device > > - list usb cont

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-18 Thread Juergen Gross
On 06/18/2015 02:08 PM, George Dunlap wrote: On 06/17/2015 12:24 PM, Ian Campbell wrote: On Tue, 2015-06-16 at 12:44 +0100, Ian Jackson wrote: George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): On Tue, Jun 16, 2015 at 12:19 PM, Juergen Gross wrote: I

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-18 Thread Juergen Gross
On 06/18/2015 10:50 AM, Ian Campbell wrote: On Thu, 2015-06-18 at 09:02 +0200, Juergen Gross wrote: On 06/18/2015 08:20 AM, Chun Yan Liu wrote: On 6/17/2015 at 07:34 PM, in message <1434540857.13744.334.ca...@citrix.com>, Ian Campbell wrote: On Tue, 2015-06-16 at 16:20 +0200, Juergen Gros

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-18 Thread George Dunlap
On 06/17/2015 12:24 PM, Ian Campbell wrote: > On Tue, 2015-06-16 at 12:44 +0100, Ian Jackson wrote: >> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): >>> On Tue, Jun 16, 2015 at 12:19 PM, Juergen Gross wrote: >>>> I'

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-18 Thread George Dunlap
On 06/17/2015 12:24 PM, Ian Campbell wrote: > On Tue, 2015-06-16 at 12:44 +0100, Ian Jackson wrote: >> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): >>> On Tue, Jun 16, 2015 at 12:19 PM, Juergen Gross wrote: >>>> I'

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-18 Thread Ian Campbell
On Thu, 2015-06-18 at 09:02 +0200, Juergen Gross wrote: > On 06/18/2015 08:20 AM, Chun Yan Liu wrote: > > > > > On 6/17/2015 at 07:34 PM, in message > <1434540857.13744.334.ca...@citrix.com>, > > Ian Campbell wrote: > >> On Tue, 2015-06-16 at 16:20 +0200, Juergen Gross wrote: > >>> My p

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-18 Thread Juergen Gross
On 06/18/2015 08:20 AM, Chun Yan Liu wrote: On 6/17/2015 at 07:34 PM, in message <1434540857.13744.334.ca...@citrix.com>, Ian Campbell wrote: On Tue, 2015-06-16 at 16:20 +0200, Juergen Gross wrote: My point was to avoid the sysfs accesses in libxl in order to support BSD as well and to red

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-17 Thread Chun Yan Liu
> >> wrote: > >>> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add > >>> pvusb API [and 1 more messages]"): > >>>>> Yes. The whole point of paths like this is that they are stable if > >>>>> the physi

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-17 Thread Chun Yan Liu
>>> On 6/17/2015 at 07:34 PM, in message >>> <1434540857.13744.334.ca...@citrix.com>, Ian Campbell wrote: > On Tue, 2015-06-16 at 16:20 +0200, Juergen Gross wrote: > > My point was to avoid the sysfs accesses in libxl in order to support > > BSD as well and to reduce the complexity. > > A

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-17 Thread Ross Philipson
On 06/17/2015 12:03 AM, Jürgen Groß wrote: On 06/16/2015 06:51 PM, Ross Philipson wrote: On 06/16/2015 12:39 PM, George Dunlap wrote: On 06/16/2015 05:32 PM, Ian Jackson wrote: I have just discovered that the value used in /dev/disk/by-path is not from sysfs, or at least, not directly. udev c

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-17 Thread Juergen Gross
On 06/17/2015 01:34 PM, Ian Campbell wrote: On Tue, 2015-06-16 at 16:20 +0200, Juergen Gross wrote: My point was to avoid the sysfs accesses in libxl in order to support BSD as well and to reduce the complexity. As a slight aside to this, can't libxl use libusb for a lot of this stuff and ther

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-17 Thread Ian Campbell
On Tue, 2015-06-16 at 16:20 +0200, Juergen Gross wrote: > My point was to avoid the sysfs accesses in libxl in order to support > BSD as well and to reduce the complexity. As a slight aside to this, can't libxl use libusb for a lot of this stuff and therefore avoid being Linux specific? http://li

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-17 Thread Ian Campbell
On Tue, 2015-06-16 at 12:44 +0100, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > > On Tue, Jun 16, 2015 at 12:19 PM, Juergen Gross wrote: > > > I'm pretty sure this is just a matter of timing during boot: the

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-17 Thread George Dunlap
On 06/17/2015 04:59 AM, Juergen Gross wrote: > On 06/16/2015 06:34 PM, George Dunlap wrote: >> On Tue, Jun 16, 2015 at 4:59 PM, Ian Jackson >> wrote: >>> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add >>> pvusb API [and 1 more messages]&q

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Jürgen Groß
On 06/16/2015 06:51 PM, Ross Philipson wrote: On 06/16/2015 12:39 PM, George Dunlap wrote: On 06/16/2015 05:32 PM, Ian Jackson wrote: I have just discovered that the value used in /dev/disk/by-path is not from sysfs, or at least, not directly. udev cobbles it together with a bunch of string ma

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-16 Thread Juergen Gross
On 06/16/2015 06:34 PM, George Dunlap wrote: On Tue, Jun 16, 2015 at 4:59 PM, Ian Jackson wrote: George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]"): Yes. The whole point of paths like this is that they are stable if the physica

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ross Philipson
On 06/16/2015 12:39 PM, George Dunlap wrote: On 06/16/2015 05:32 PM, Ian Jackson wrote: I have just discovered that the value used in /dev/disk/by-path is not from sysfs, or at least, not directly. udev cobbles it together with a bunch of string mangling, from information mostly from sysfs. Th

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ian Jackson
I have just discovered that the value used in /dev/disk/by-path is not from sysfs, or at least, not directly. udev cobbles it together with a bunch of string mangling, from information mostly from sysfs. There is no corresponding thing for usb devices. So Linux, the kernel, does not actually pro

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On 06/16/2015 05:32 PM, Ian Jackson wrote: > I have just discovered that the value used in /dev/disk/by-path is not > from sysfs, or at least, not directly. > > udev cobbles it together with a bunch of string mangling, from > information mostly from sysfs. There is no corresponding thing for > us

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 4:59 PM, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API > [and 1 more messages]"): >> > Yes. The whole point of paths like this is that they are stable if >> > the physical topology

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-16 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]"): > On 06/16/2015 02:37 PM, Ian Jackson wrote: > > George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb > > API"> >> /sys/devices/pc

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-16 Thread Sander Eikelenboom
Tuesday, June 16, 2015, 4:41:52 PM, you wrote: > On 06/16/2015 02:37 PM, Ian Jackson wrote: >> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): >>> Remember that the path you gave in your previous e-mail isn't the path >>> f

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 12:25 PM, Juergen Gross wrote: > Yes, they have. The question is whether those are different on multiple > instances? With "lsusb" I've found a device with serial number > 0123456789ABCD. Do you really believe I'm just lucky owning the one with > such a nice serial number?

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-16 Thread George Dunlap
On 06/16/2015 02:37 PM, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): >> Remember that the path you gave in your previous e-mail isn't the path >> for the *usb device*, it's the path for the *block device*. I

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On 06/16/2015 03:20 PM, Juergen Gross wrote: > On 06/16/2015 04:06 PM, George Dunlap wrote: >> On 06/16/2015 02:49 PM, Juergen Gross wrote: >>> On 06/16/2015 03:29 PM, George Dunlap wrote: On 06/16/2015 02:23 PM, Juergen Gross wrote: > Hmm, I'd rather have it all in one place. Putting it i

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 04:06 PM, George Dunlap wrote: On 06/16/2015 02:49 PM, Juergen Gross wrote: On 06/16/2015 03:29 PM, George Dunlap wrote: On 06/16/2015 02:23 PM, Juergen Gross wrote: Hmm, I'd rather have it all in one place. Putting it in qemu would enable us to handle hotplug as well. A USB devi

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On 06/16/2015 02:49 PM, Juergen Gross wrote: > On 06/16/2015 03:29 PM, George Dunlap wrote: >> On 06/16/2015 02:23 PM, Juergen Gross wrote: >>> Hmm, I'd rather have it all in one place. Putting it in qemu would >>> enable us to handle hotplug as well. A USB device assigned via it's >>> serial to a

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 03:29 PM, George Dunlap wrote: On 06/16/2015 02:23 PM, Juergen Gross wrote: On 06/16/2015 03:09 PM, George Dunlap wrote: On 06/16/2015 02:06 PM, Juergen Gross wrote: On 06/16/2015 01:45 PM, Ian Jackson wrote: Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-16 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > Remember that the path you gave in your previous e-mail isn't the path > for the *usb device*, it's the path for the *block device*. It > contains a PCI address, but it looks like it al

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 03:19 PM, George Dunlap wrote: On Tue, Jun 16, 2015 at 1:02 PM, Ian Jackson wrote: George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): So it sounds like we're converging on "Allow multiple ways to specify the interface", wi

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On 06/16/2015 02:23 PM, Juergen Gross wrote: > On 06/16/2015 03:09 PM, George Dunlap wrote: >> On 06/16/2015 02:06 PM, Juergen Gross wrote: >>> On 06/16/2015 01:45 PM, Ian Jackson wrote: >>>> Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 03:09 PM, George Dunlap wrote: On 06/16/2015 02:06 PM, Juergen Gross wrote: On 06/16/2015 01:45 PM, Ian Jackson wrote: Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): On 06/16/2015 01:10 PM, Ian Jackson wrote: AIUI some devices have seri

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 1:02 PM, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): >> So it sounds like we're converging on "Allow multiple ways to specify >> the interface", with at least the following fiel

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On 06/16/2015 02:06 PM, Juergen Gross wrote: > On 06/16/2015 01:45 PM, Ian Jackson wrote: >> Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb >> API"): >>> On 06/16/2015 01:10 PM, Ian Jackson wrote: >>>> AIUI some devices have s

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 01:45 PM, Ian Jackson wrote: Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): On 06/16/2015 01:10 PM, Ian Jackson wrote: AIUI some devices have serial numbers, which means you can distinguish them ? Yes, they have. The question is whether

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > So it sounds like we're converging on "Allow multiple ways to specify > the interface", with at least the following fields: > - bus (int - 1,2,3, &c) > - port (string - 2.1.3,

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ian Jackson
Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > On 06/16/2015 01:10 PM, Ian Jackson wrote: > > AIUI some devices have serial numbers, which means you can distinguish > > them ? > > Yes, they have. The question is whether those are di

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > On Tue, Jun 16, 2015 at 12:19 PM, Juergen Gross wrote: > > I'm pretty sure this is just a matter of timing during boot: the busses > > are all (or at least some of them) queried at t

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 12:25 PM, Juergen Gross wrote: >>> qemu does support specifying a USB device via :, >>> which is stable even across reboots, but unfortunately it isn't >>> guaranteed to be unique (you can have plugged in two devices of the >>> same type). >> >> >> Indeed. That would also

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 01:10 PM, Ian Jackson wrote: Jürgen Groß writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): On 06/16/2015 12:41 PM, Ian Jackson wrote: Is the busid more stable in the face of plug/unplug ? This is the normal reason for a more path-like device spe

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 12:19 PM, Juergen Gross wrote: > On 06/16/2015 01:11 PM, George Dunlap wrote: >> >> On Tue, Jun 16, 2015 at 11:51 AM, Juergen Gross wrote: The "busid" interface that Chunyan is describing requires the caller to find out that long name -- 2-3.1.2 -- rather th

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 12:12 PM, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): >> The "busid" we're talking about here will identify a device at a >> particular *port* in the USB topology; the busid wi

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 01:11 PM, George Dunlap wrote: On Tue, Jun 16, 2015 at 11:51 AM, Juergen Gross wrote: The "busid" interface that Chunyan is describing requires the caller to find out that long name -- 2-3.1.2 -- rather than the traditional short name (002:010). Just accepting "2-3" is not suffic

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > The "busid" we're talking about here will identify a device at a > particular *port* in the USB topology; the busid will take whatever is > plugged into that particular port. So i

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 11:51 AM, Juergen Gross wrote: >> The "busid" interface that Chunyan is describing requires the caller >> to find out that long name -- 2-3.1.2 -- rather than the traditional >> short name (002:010). Just accepting "2-3" is not sufficient. > > > qemu with my patch will fin

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ian Jackson
Jürgen Groß writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > On 06/16/2015 12:41 PM, Ian Jackson wrote: > > Is the busid more stable in the face of plug/unplug ? This is the > > normal reason for a more path-like device specification. ... > Unfortunate

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 11:56 AM, Jürgen Groß wrote: > On 06/16/2015 12:41 PM, Ian Jackson wrote: >> >> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb >> API"): >>> >>> Ian / Ian / Wei / Jim: >> >> >>

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Tue, Jun 16, 2015 at 11:41 AM, Ian Jackson wrote: >> 3. Have the libxl layer accept both busid and bus:addr. Translate as >> necessary and store in the libxl_device_usb struct. > ... >> The advantage of #3 internally is that the functions can do the >> translation once (if necessary), and can

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Jürgen Groß
On 06/16/2015 12:41 PM, Ian Jackson wrote: George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): Ian / Ian / Wei / Jim: Hi. 3. Have the libxl layer accept both busid and bus:addr. Translate as necessary and store in the libxl_device_usb struct. ... The

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Juergen Gross
On 06/16/2015 12:30 PM, George Dunlap wrote: On Mon, Jun 15, 2015 at 7:26 PM, Juergen Gross wrote: On 06/15/2015 04:34 PM, George Dunlap wrote: On Mon, Jun 15, 2015 at 3:25 PM, Jürgen Groß wrote: On 06/15/2015 04:17 PM, George Dunlap wrote: On Wed, Jun 10, 2015 at 4:20 AM, Chunyan Liu

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > Ian / Ian / Wei / Jim: Hi. > 3. Have the libxl layer accept both busid and bus:addr. Translate as > necessary and store in the libxl_device_usb struct. ... > The advantage of #3 internally is

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread George Dunlap
On Mon, Jun 15, 2015 at 7:26 PM, Juergen Gross wrote: > On 06/15/2015 04:34 PM, George Dunlap wrote: >> >> On Mon, Jun 15, 2015 at 3:25 PM, Jürgen Groß wrote: >>> >>> On 06/15/2015 04:17 PM, George Dunlap wrote: On Wed, Jun 10, 2015 at 4:20 AM, Chunyan Liu wrote: > > >

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-15 Thread Juergen Gross
On 06/15/2015 04:34 PM, George Dunlap wrote: On Mon, Jun 15, 2015 at 3:25 PM, Jürgen Groß wrote: On 06/15/2015 04:17 PM, George Dunlap wrote: On Wed, Jun 10, 2015 at 4:20 AM, Chunyan Liu wrote: diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 23f27d4..4561e1b 10

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-15 Thread George Dunlap
On 06/10/2015 04:20 AM, Chunyan Liu wrote: > Add pvusb APIs, including: > - attach/detach (create/destroy) virtual usb controller. > - attach/detach usb device > - list usb controller and usb devices > - some other helper functions > > Signed-off-by: Chunyan Liu > Signed-off-by: Simon Cao >

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-15 Thread George Dunlap
On Mon, Jun 15, 2015 at 3:25 PM, Jürgen Groß wrote: > On 06/15/2015 04:17 PM, George Dunlap wrote: >> >> On Wed, Jun 10, 2015 at 4:20 AM, Chunyan Liu wrote: >>> >>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl >>> index 23f27d4..4561e1b 100644 >>> --- a/tools/libxl/libxl

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-15 Thread Jürgen Groß
On 06/15/2015 04:17 PM, George Dunlap wrote: On Wed, Jun 10, 2015 at 4:20 AM, Chunyan Liu wrote: diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 23f27d4..4561e1b 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -541,6 +541,29 @@ libxl_de

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-15 Thread George Dunlap
On Wed, Jun 10, 2015 at 4:20 AM, Chunyan Liu wrote: > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index 23f27d4..4561e1b 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -541,6 +541,29 @@ libxl_device_pci = Struct("device_pci", [ >

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-12 Thread Ian Jackson
Chun Yan Liu writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > <21881.47707.526863.158...@mariner.uk.xensource.com>, Ian Jackson > wrote: > > Chunyan Liu writes ("[Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > > > +int libxl_

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-12 Thread Chun Yan Liu
>>> On 6/12/2015 at 03:39 PM, in message <557afd2f0266000d4...@relay2.provo.novell.com>, "Chun Yan Liu" wrote: > >>>> On 6/12/2015 at 12:42 AM, in message > <21881.47707.526863.158...@mariner.uk.xensource.com>, Ian Jackson > wrote:

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-12 Thread Chun Yan Liu
>>> On 6/12/2015 at 12:42 AM, in message <21881.47707.526863.158...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > > Add pvusb APIs, including: > ... > > Thanks for your c

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-11 Thread Ian Jackson
Chunyan Liu writes ("[Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > Add pvusb APIs, including: ... Thanks for your contribution. I'm afraid I haven't had time to completely finish my review this, but here's what I have: > --- /dev/null > +++ b/docs/misc/

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-11 Thread Ian Jackson
Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > The second async operation is being called with ao_how being NULL, but > I'm not sure whether this is allowed (libxl_internal.h comments are not > clear for me regarding such a scenario). It is

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-11 Thread Juergen Gross
On 06/10/2015 05:20 AM, Chunyan Liu wrote: Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list usb controller and usb devices - some other helper functions Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao I've teste

[Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-09 Thread Chunyan Liu
Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list usb controller and usb devices - some other helper functions Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao --- changes: - make libxl_device_usbctrl_add async, to be