Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
>>> On 10.02.15 at 19:03, wrote: > On Tue, Feb 10, 2015 at 6:39 PM, Jan Beulich wrote: > Tamas K Lengyel 02/10/15 5:38 PM >>> >>>On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: >>> Tamas K Lengyel 02/10/15 2:51 PM >>> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: >>

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 6:39 PM, Jan Beulich wrote: Tamas K Lengyel 02/10/15 5:38 PM >>> >>On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: >> Tamas K Lengyel 02/10/15 2:51 PM >>> >>> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: >>> On 09.02.15 at 19:53, wrote: >> @

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
>>> Tamas K Lengyel 02/10/15 5:38 PM >>> >On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: > Tamas K Lengyel 02/10/15 2:51 PM >>> >> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: >> On 09.02.15 at 19:53, wrote: > @@ -598,6 +600,12 @@ int mem_sharing_sharing_resume(struct d

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: Tamas K Lengyel 02/10/15 2:51 PM >>> > On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: > On 09.02.15 at 19:53, wrote: @@ -598,6 +600,12 @@ int mem_sharing_sharing_resume(struct domain *d) { struct vcpu

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
>>> Tamas K Lengyel 02/10/15 2:51 PM >>> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: On 09.02.15 at 19:53, wrote: >>> @@ -598,6 +600,12 @@ int mem_sharing_sharing_resume(struct domain *d) >>> { >>> struct vcpu *v; >>> >>> +if ( rsp.version != MEM_EVENT_INTERFAC

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: On 09.02.15 at 19:53, wrote: >> +static void hvm_memory_event_cr(uint32_t reason, unsigned long value, >> +unsigned long old) >> +{ >> +mem_event_request_t req = { >> +.reason = reason, >> +

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
>>> On 09.02.15 at 19:53, wrote: > +static void hvm_memory_event_cr(uint32_t reason, unsigned long value, > +unsigned long old) > +{ > +mem_event_request_t req = { > +.reason = reason, > +.vcpu_id = current->vcpu_id, > +.u.mov_to_cr.new_v

[Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-09 Thread Tamas K Lengyel
From: Razvan Cojocaru The public mem_event structures used to communicate with helper applications via shared rings have been used in different settings. However, the variable names within this structure have not reflected this fact, resulting in the reuse of variables to mean different things un