Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-07-06 Thread Razvan Cojocaru
On 07/06/2015 01:27 PM, Jan Beulich wrote: >>> No XSM check here or in the handler? Shouldn't the admin controlling >>> guest properties from the host perspective be permitted control here? >>> Cc-ing Daniel for his input ... >> >> Thinking more about this, the goal here is to be able to monitor >>

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-07-06 Thread Lengyel, Tamas
On Mon, Jul 6, 2015 at 6:26 AM, Jan Beulich wrote: > >>> On 30.06.15 at 16:48, wrote: > >> > --- a/xen/include/asm-x86/domain.h > > > >> >> +++ b/xen/include/asm-x86/domain.h > >> >> @@ -342,13 +342,15 @@ struct arch_domain > >> >> > >> >> /* Monitor options */ > >> >> struct { > >> >>

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-07-06 Thread Jan Beulich
>>> On 30.06.15 at 16:23, wrote: > On 06/26/2015 10:02 AM, Jan Beulich wrote: > On 15.06.15 at 11:03, wrote: >>> Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST, >>> sent via HVMOP_request_vm_event. The guest can request that a >>> generic vm_event (containing only the vm_

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-07-06 Thread Jan Beulich
>>> On 30.06.15 at 16:48, wrote: >> > --- a/xen/include/asm-x86/domain.h > >> >> +++ b/xen/include/asm-x86/domain.h >> >> @@ -342,13 +342,15 @@ struct arch_domain >> >> >> >> /* Monitor options */ >> >> struct { >> >> -uint16_t write_ctrlreg_enabled : 4; >> >> -uin

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-07-01 Thread Razvan Cojocaru
On 06/30/2015 05:48 PM, Lengyel, Tamas wrote: >>> --- a/xen/include/asm-x86/domain.h > > >> +++ b/xen/include/asm-x86/domain.h > >> @@ -342,13 +342,15 @@ struct arch_domain > >> > >> /* Monitor options */ > >> struct { > >> -uint16_t write_ctrlreg_enabled

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-30 Thread Razvan Cojocaru
On 06/30/2015 05:48 PM, Lengyel, Tamas wrote: >>> --- a/xen/include/asm-x86/domain.h > > >> +++ b/xen/include/asm-x86/domain.h > >> @@ -342,13 +342,15 @@ struct arch_domain > >> > >> /* Monitor options */ > >> struct { > >> -uint16_t write_ctrlreg_enabled

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-30 Thread Lengyel, Tamas
>> --- a/xen/include/asm-x86/domain.h > >> +++ b/xen/include/asm-x86/domain.h > >> @@ -342,13 +342,15 @@ struct arch_domain > >> > >> /* Monitor options */ > >> struct { > >> -uint16_t write_ctrlreg_enabled : 4; > >> -uint16_t write_ctrlreg_sync : 4; > >> -

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-30 Thread Razvan Cojocaru
On 06/26/2015 10:02 AM, Jan Beulich wrote: On 15.06.15 at 11:03, wrote: >> Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST, >> sent via HVMOP_request_vm_event. The guest can request that a >> generic vm_event (containing only the vm_event-filled guest registers >> as infor

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-26 Thread Jan Beulich
>>> On 26.06.15 at 09:17, wrote: > On 06/26/2015 10:02 AM, Jan Beulich wrote: > On 15.06.15 at 11:03, wrote: >>> --- a/xen/include/public/hvm/hvm_op.h >>> +++ b/xen/include/public/hvm/hvm_op.h >>> @@ -389,6 +389,10 @@ >>> DEFINE_XEN_GUEST_HANDLE(xen_hvm_evtchn_upcall_vector_t); >>> >>> #e

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-26 Thread Razvan Cojocaru
On 06/26/2015 10:02 AM, Jan Beulich wrote: On 15.06.15 at 11:03, wrote: >> Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST, >> sent via HVMOP_request_vm_event. The guest can request that a >> generic vm_event (containing only the vm_event-filled guest registers >> as infor

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-26 Thread Jan Beulich
>>> On 15.06.15 at 11:03, wrote: > Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST, > sent via HVMOP_request_vm_event. The guest can request that a > generic vm_event (containing only the vm_event-filled guest registers > as information) be sent to userspace by setting up the c

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-25 Thread Razvan Cojocaru
On 06/25/2015 11:37 AM, Jan Beulich wrote: On 25.06.15 at 09:55, wrote: >> On 06/24/2015 06:03 PM, Jan Beulich wrote: >> On 24.06.15 at 16:56, wrote: Would it be fair to say that HVMOP_request_vm_event should be an exception to this rule (i.e. something along the lines of "if (

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-25 Thread Jan Beulich
>>> On 25.06.15 at 09:55, wrote: > On 06/24/2015 06:03 PM, Jan Beulich wrote: > On 24.06.15 at 16:56, wrote: >>> Would it be fair to say that HVMOP_request_vm_event should be an >>> exception to this rule (i.e. something along the lines of "if ( >>> unlikely(r12 == HVMOP_request_vm_event) &&

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-25 Thread Razvan Cojocaru
On 06/24/2015 06:03 PM, Jan Beulich wrote: On 24.06.15 at 16:56, wrote: >> Would it be fair to say that HVMOP_request_vm_event should be an >> exception to this rule (i.e. something along the lines of "if ( >> unlikely(r12 == HVMOP_request_vm_event) && orig_pc == regs->pc )", >> etc.)? Even i

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-24 Thread Jan Beulich
>>> On 24.06.15 at 16:56, wrote: > On 06/15/2015 12:03 PM, Razvan Cojocaru wrote: >> Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST, >> sent via HVMOP_request_vm_event. The guest can request that a >> generic vm_event (containing only the vm_event-filled guest registers >> as

Re: [Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-24 Thread Razvan Cojocaru
On 06/15/2015 12:03 PM, Razvan Cojocaru wrote: > Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST, > sent via HVMOP_request_vm_event. The guest can request that a > generic vm_event (containing only the vm_event-filled guest registers > as information) be sent to userspace by set

[Xen-devel] [PATCH V2 2/3] xen/vm_event: Support for guest-requested events

2015-06-15 Thread Razvan Cojocaru
Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST, sent via HVMOP_request_vm_event. The guest can request that a generic vm_event (containing only the vm_event-filled guest registers as information) be sent to userspace by setting up the correct registers and doing a VMCALL. For e