Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Razvan Cojocaru
On 03/23/2017 06:20 PM, Jan Beulich wrote: On 23.03.17 at 16:54, wrote: >> I'm not sure where to go from here. > > Well, without finding where things start to go wrong, I don't think > we can make any progress here. Finding that may admittedly be > a rather tedious process. I may have stumb

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Jan Beulich
>>> On 23.03.17 at 16:54, wrote: > I'm not sure where to go from here. Well, without finding where things start to go wrong, I don't think we can make any progress here. Finding that may admittedly be a rather tedious process. Jan ___ Xen-devel maili

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Razvan Cojocaru
On 03/23/2017 03:23 PM, Jan Beulich wrote: On 23.03.17 at 11:21, wrote: >>> Sadly, I've now written this (rough) patch: >>> >>> http://pastebin.com/3DJ5WYt0 >>> >>> only to find that it does not solve our issue. With multiple processors >>> per guest and heavy emulati

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Razvan Cojocaru
On 03/23/2017 03:23 PM, Jan Beulich wrote: On 23.03.17 at 11:21, wrote: >>> Sadly, I've now written this (rough) patch: >>> >>> http://pastebin.com/3DJ5WYt0 >>> >>> only to find that it does not solve our issue. With multiple processors >>> per guest and heavy emulati

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Jan Beulich
>>> On 23.03.17 at 11:21, wrote: >> Sadly, I've now written this (rough) patch: >> >> http://pastebin.com/3DJ5WYt0 >> >> only to find that it does not solve our issue. With multiple processors >> per guest and heavy emulation at boot time, the VM got stuck at roughly >

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Razvan Cojocaru
> Sadly, I've now written this (rough) patch: > > http://pastebin.com/3DJ5WYt0 > > only to find that it does not solve our issue. With multiple processors > per guest and heavy emulation at boot time, the VM got stuck at roughly > the same point in its life as before th

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Razvan Cojocaru
On 03/23/2017 10:45 AM, Jan Beulich wrote: On 23.03.17 at 09:27, wrote: >> On 03/23/2017 10:19 AM, Jan Beulich wrote: >> On 22.03.17 at 18:22, wrote: On 03/21/2017 07:02 PM, Jan Beulich wrote: On 21.03.17 at 17:44, wrote: >> On 03/21/2017 06:29 PM, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Jan Beulich
>>> On 23.03.17 at 09:27, wrote: > On 03/23/2017 10:19 AM, Jan Beulich wrote: > On 22.03.17 at 18:22, wrote: >>> On 03/21/2017 07:02 PM, Jan Beulich wrote: >>> On 21.03.17 at 17:44, wrote: > On 03/21/2017 06:29 PM, Jan Beulich wrote: > On 21.03.17 at 16:38, wrote: >>> On

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Razvan Cojocaru
On 03/23/2017 10:19 AM, Jan Beulich wrote: On 22.03.17 at 18:22, wrote: >> On 03/21/2017 07:02 PM, Jan Beulich wrote: >> On 21.03.17 at 17:44, wrote: On 03/21/2017 06:29 PM, Jan Beulich wrote: On 21.03.17 at 16:38, wrote: >> On 03/15/2017 06:57 PM, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-23 Thread Jan Beulich
>>> On 22.03.17 at 18:22, wrote: > On 03/21/2017 07:02 PM, Jan Beulich wrote: > On 21.03.17 at 17:44, wrote: >>> On 03/21/2017 06:29 PM, Jan Beulich wrote: >>> On 21.03.17 at 16:38, wrote: > On 03/15/2017 06:57 PM, Jan Beulich wrote: > On 15.03.17 at 17:46, wrote: >>> On

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-22 Thread Razvan Cojocaru
On 03/21/2017 07:02 PM, Jan Beulich wrote: On 21.03.17 at 17:44, wrote: >> On 03/21/2017 06:29 PM, Jan Beulich wrote: >> On 21.03.17 at 16:38, wrote: On 03/15/2017 06:57 PM, Jan Beulich wrote: On 15.03.17 at 17:46, wrote: >> On 03/15/2017 06:30 PM, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-21 Thread Jan Beulich
>>> On 21.03.17 at 17:44, wrote: > On 03/21/2017 06:29 PM, Jan Beulich wrote: > On 21.03.17 at 16:38, wrote: >>> On 03/15/2017 06:57 PM, Jan Beulich wrote: >>> On 15.03.17 at 17:46, wrote: > On 03/15/2017 06:30 PM, Jan Beulich wrote: > On 15.03.17 at 17:04, wrote: >>> --

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-21 Thread Razvan Cojocaru
On 03/21/2017 06:29 PM, Jan Beulich wrote: On 21.03.17 at 16:38, wrote: >> On 03/15/2017 06:57 PM, Jan Beulich wrote: >> On 15.03.17 at 17:46, wrote: On 03/15/2017 06:30 PM, Jan Beulich wrote: On 15.03.17 at 17:04, wrote: >> --- >> Changes since V1: >> - Added

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-21 Thread Jan Beulich
>>> On 21.03.17 at 16:38, wrote: > On 03/15/2017 06:57 PM, Jan Beulich wrote: > On 15.03.17 at 17:46, wrote: >>> On 03/15/2017 06:30 PM, Jan Beulich wrote: >>> On 15.03.17 at 17:04, wrote: > --- > Changes since V1: > - Added Andrew Cooper's credit, as he's kept the patch cur

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-21 Thread Razvan Cojocaru
On 03/21/2017 05:38 PM, Razvan Cojocaru wrote: > On 03/15/2017 06:57 PM, Jan Beulich wrote: > On 15.03.17 at 17:46, wrote: >>> On 03/15/2017 06:30 PM, Jan Beulich wrote: >>> On 15.03.17 at 17:04, wrote: > --- > Changes since V1: > - Added Andrew Cooper's credit, as he's kept

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-21 Thread Razvan Cojocaru
On 03/15/2017 06:57 PM, Jan Beulich wrote: On 15.03.17 at 17:46, wrote: >> On 03/15/2017 06:30 PM, Jan Beulich wrote: >> On 15.03.17 at 17:04, wrote: --- Changes since V1: - Added Andrew Cooper's credit, as he's kept the patch current througout non-trivial code ch

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-15 Thread Jan Beulich
>>> On 15.03.17 at 17:46, wrote: > On 03/15/2017 06:30 PM, Jan Beulich wrote: > On 15.03.17 at 17:04, wrote: >>> --- >>> Changes since V1: >>> - Added Andrew Cooper's credit, as he's kept the patch current >>>througout non-trivial code changes since the initial patch. >>> - Significantl

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-15 Thread Razvan Cojocaru
On 03/15/2017 06:30 PM, Jan Beulich wrote: On 15.03.17 at 17:04, wrote: >> --- >> Changes since V1: >> - Added Andrew Cooper's credit, as he's kept the patch current >>througout non-trivial code changes since the initial patch. >> - Significantly more patch testing (with XenServer). >>

Re: [Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-15 Thread Jan Beulich
>>> On 15.03.17 at 17:04, wrote: > --- > Changes since V1: > - Added Andrew Cooper's credit, as he's kept the patch current >througout non-trivial code changes since the initial patch. > - Significantly more patch testing (with XenServer). > - Restricted lock scope. Not by much, as it seem

[Xen-devel] [PATCH V2] x86/emulate: synchronize LOCKed instruction emulation

2017-03-15 Thread Razvan Cojocaru
LOCK-prefixed instructions are currenly allowed to run in parallel in x86_emulate(), which can lead the guest into an undefined state. This patch fixes the issue. Signed-off-by: Razvan Cojocaru Signed-off-by: Andrew Cooper --- Changes since V1: - Added Andrew Cooper's credit, as he's kept the