Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-28 Thread Jan Beulich
>>> On 27.09.16 at 19:49, wrote: > On Mon, Sep 26, 2016 at 07:37:45AM -0600, Jan Beulich wrote: >> >>> On 23.09.16 at 23:47, wrote: >> > --- a/xen/common/efi/boot.c >> > +++ b/xen/common/efi/boot.c >> > @@ -79,6 +79,10 @@ static size_t wstrlen(const CHAR16 * s); >> > static int set_color(u32 mas

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-27 Thread Julien Grall
Hi Jan, On 27/09/2016 01:06, Jan Beulich wrote: On 26.09.16 at 22:01, wrote: On 25/09/2016 23:53, Jan Beulich wrote: On 24.09.16 at 01:35, wrote: On 23/09/2016 22:47, Daniel Kiper wrote: @@ -66,6 +67,7 @@ integer_param("xenheap_megabytes", opt_xenheap_megabytes); static __used void init_

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-27 Thread Daniel Kiper
On Mon, Sep 26, 2016 at 07:37:45AM -0600, Jan Beulich wrote: > >>> On 23.09.16 at 23:47, wrote: > > --- a/xen/common/efi/boot.c > > +++ b/xen/common/efi/boot.c > > @@ -79,6 +79,10 @@ static size_t wstrlen(const CHAR16 * s); > > static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz); > > static

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-27 Thread Jan Beulich
>>> On 26.09.16 at 22:01, wrote: > On 25/09/2016 23:53, Jan Beulich wrote: > On 24.09.16 at 01:35, wrote: >>> On 23/09/2016 22:47, Daniel Kiper wrote: @@ -66,6 +67,7 @@ integer_param("xenheap_megabytes", opt_xenheap_megabytes); static __used void init_done(void) {

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-26 Thread Julien Grall
Hi Jan, On 25/09/2016 23:53, Jan Beulich wrote: On 24.09.16 at 01:35, wrote: Hi Daniel, On 23/09/2016 22:47, Daniel Kiper wrote: diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 38eb888..2085f35 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -38,6 +38,7 @@ #in

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-26 Thread Jan Beulich
>>> On 23.09.16 at 23:47, wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -79,6 +79,10 @@ static size_t wstrlen(const CHAR16 * s); > static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz); > static bool_t match_guid(const EFI_GUID *guid1, const EFI_GUID *guid2); > > +

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-25 Thread Jan Beulich
>>> On 24.09.16 at 01:35, wrote: > Hi Daniel, > > On 23/09/2016 22:47, Daniel Kiper wrote: >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index 38eb888..2085f35 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -38,6 +38,7 @@ >> #include >> #include >>

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-23 Thread Julien Grall
Hi Daniel, On 23/09/2016 22:47, Daniel Kiper wrote: diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 38eb888..2085f35 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -66,6

[Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

2016-09-23 Thread Daniel Kiper
There is a problem with place_string() which is used as early memory allocator. It gets memory chunks starting from start symbol and goes down. Sadly this does not work when Xen is loaded using multiboot2 protocol because then the start lives on 1 MiB address and we should not allocate a memory fro