On Tue, Jan 3, 2017 at 5:45 PM, Ronald Rojas wrote:
>> > +/*
>> > +#cgo LDFLAGS: -lxenlight -lyajl
>> > +#include
>> > +#include
>> > +*/
>> > +import "C"
>>
>> I see you switched back to dynamic linking -- any particular reason?
>>
>> We probably need to put a "// FIXME" here saying that we nee
On Thu, Dec 29, 2016 at 01:45:54PM +, George Dunlap wrote:
> Hey Ronald! Looks like you're getting going pretty well here.
>
> At a high level: I think I began by saying that this would probably all
> be a single patch. But I think it would probably be easier to review
> the different decisi
On Thu, Dec 29, 2016 at 1:45 PM, George Dunlap wrote:
> At a high level: I think I began by saying that this would probably all
> be a single patch. But I think it would probably be easier to review
> the different decisions made at each point by filling out the file bit
> by bit, and explaining
On Thu, Dec 29, 2016 at 10:52:42AM +, Wei Liu wrote:
> On Thu, Dec 29, 2016 at 10:34:34AM +, George Dunlap wrote:
> > On 29/12/16 01:14, Ronald Rojas wrote:
> > > Create interface to interact with libxl_verions_info
> > > and libxl_physinfo. Also introduce proper error
> > > handling.
> > >
Hey Ronald! Looks like you're getting going pretty well here.
At a high level: I think I began by saying that this would probably all
be a single patch. But I think it would probably be easier to review
the different decisions made at each point by filling out the file bit
by bit, and explaining
On Thu, Dec 29, 2016 at 10:34:34AM +, George Dunlap wrote:
> On 29/12/16 01:14, Ronald Rojas wrote:
> > Create interface to interact with libxl_verions_info
> > and libxl_physinfo. Also introduce proper error
> > handling.
> >
> > Signed-off-by: Ronald Rojas
>
> Hey Ronald,
>
> When you sen
On 29/12/16 01:14, Ronald Rojas wrote:
> Create interface to interact with libxl_verions_info
> and libxl_physinfo. Also introduce proper error
> handling.
>
> Signed-off-by: Ronald Rojas
Hey Ronald,
When you send a series to a public open-source project, you want it to
be a sort of idealized s
Create interface to interact with libxl_verions_info
and libxl_physinfo. Also introduce proper error
handling.
Signed-off-by: Ronald Rojas
---
tools/golang/xenlight/libxl.go| 720 --
tools/golang/xenlight/xenlight.go | 1000 +
2 fi
