Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-16 Thread Boris Ostrovsky
On 06/16/2016 04:54 AM, Wei Liu wrote: > On Mon, Jun 06, 2016 at 11:15:22AM -0400, Boris Ostrovsky wrote: > [...] >>> +static int init_acpi_config(struct xc_dom_image *dom, >>> +struct acpi_config *config) >>> +{ >>> +xc_interface *xch = dom->xch; >>> +uint32_t d

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-16 Thread Wei Liu
On Mon, Jun 06, 2016 at 11:15:22AM -0400, Boris Ostrovsky wrote: [...] > > +static int init_acpi_config(struct xc_dom_image *dom, > > +struct acpi_config *config) > > +{ > > +xc_interface *xch = dom->xch; > > +uint32_t domid = dom->guest_domid; > > +xc_dominf

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-07 Thread Jan Beulich
>>> On 07.06.16 at 16:47, wrote: > On 06/07/2016 10:10 AM, Jan Beulich wrote: > On 07.06.16 at 15:59, wrote: >>> On 06/07/2016 02:17 AM, Jan Beulich wrote: >>> On 06.06.16 at 18:59, wrote: > On 06/06/2016 09:29 AM, Jan Beulich wrote: > On 06.04.16 at 03:25, wrote: > RESE

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-07 Thread Boris Ostrovsky
On 06/07/2016 10:10 AM, Jan Beulich wrote: On 07.06.16 at 15:59, wrote: >> On 06/07/2016 02:17 AM, Jan Beulich wrote: >> On 06.06.16 at 18:59, wrote: On 06/06/2016 09:29 AM, Jan Beulich wrote: On 06.04.16 at 03:25, wrote: >> +#define RESERVED_MEMORY_DYNAMIC_START 0xFC0

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-07 Thread Jan Beulich
>>> On 07.06.16 at 15:59, wrote: > On 06/07/2016 02:17 AM, Jan Beulich wrote: > On 06.06.16 at 18:59, wrote: >>> On 06/06/2016 09:29 AM, Jan Beulich wrote: >>> On 06.04.16 at 03:25, wrote: > +#define RESERVED_MEMORY_DYNAMIC_START 0xFC001000 > +#define ACPI_PHYSICAL_ADDRESS

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-07 Thread Boris Ostrovsky
On 06/07/2016 02:17 AM, Jan Beulich wrote: On 06.06.16 at 18:59, wrote: >> On 06/06/2016 09:29 AM, Jan Beulich wrote: >> On 06.04.16 at 03:25, wrote: +#define RESERVED_MEMORY_DYNAMIC_START 0xFC001000 +#define ACPI_PHYSICAL_ADDRESS 0x000EA020 + +/* Initial allo

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-06 Thread Jan Beulich
>>> On 06.06.16 at 18:59, wrote: > On 06/06/2016 09:29 AM, Jan Beulich wrote: > On 06.04.16 at 03:25, wrote: >>> +#define RESERVED_MEMORY_DYNAMIC_START 0xFC001000 >>> +#define ACPI_PHYSICAL_ADDRESS 0x000EA020 >>> + >>> +/* Initial allocation for ACPI tables */ >>> +#define NUM_ACPI_PA

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-06 Thread Boris Ostrovsky
On 06/06/2016 09:29 AM, Jan Beulich wrote: On 06.04.16 at 03:25, wrote: >> --- /dev/null >> +++ b/tools/libxc/xc_acpi.c >> @@ -0,0 +1,268 @@ >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include > Why are these two needed here? Th

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-06 Thread Boris Ostrovsky
On 06/06/2016 08:03 AM, Wei Liu wrote: > >> diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile >> index 608404f..9569e54 100644 >> --- a/tools/libxc/Makefile >> +++ b/tools/libxc/Makefile >> @@ -79,6 +79,26 @@ GUEST_SRCS-y += $(ELF_SRCS-y) >> $(patsubst %.c,%.o,$(ELF_SRCS-y)): CFLAGS += -Wno

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-06 Thread Jan Beulich
>>> On 06.04.16 at 03:25, wrote: > --- /dev/null > +++ b/tools/libxc/xc_acpi.c > @@ -0,0 +1,268 @@ > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include Why are these two needed here? The code here shouldn't care about the mode the guest may l

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-06 Thread Wei Liu
On Tue, Apr 05, 2016 at 09:25:47PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > tools/libxc/Makefile | 22 +++- > tools/libxc/include/xc_dom.h | 1 + > tools/libxc/xc_acpi.c | 268 > ++ > tools/libxc/x

Re: [Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-06-02 Thread Roger Pau Monné
Thanks for looking into this, I've found a couple of issues when compiling this with clang. On Tue, Apr 05, 2016 at 09:25:47PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > tools/libxc/Makefile | 22 +++- > tools/libxc/include/xc_dom.h | 1 + > tool

[Xen-devel] [PATCH RFC 18/20] libxc/acpi: Build ACPI tables for HVMlite guests

2016-04-05 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- tools/libxc/Makefile | 22 +++- tools/libxc/include/xc_dom.h | 1 + tools/libxc/xc_acpi.c | 268 ++ tools/libxc/xc_dom_x86.c | 7 + tools/libxl/libxl_x86.c | 19 +-- xen/c